[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#220949: Installer overwrites user data without warning



On Thu, May 27, 2004 at 03:41:21PM -0300, Steve McIntyre wrote:
> On Wed, May 26, 2004 at 04:10:42PM +0100, Steve McIntyre wrote:
> >From looking at the information on this bug, I'm thinking the easiest
> >way to fix this would be to add code to check the fs type on the
> >partitions we've been asked to install onto. If the fs is not
> >ext2/ext3/reiser/etc., then we should complain and (optionally) ask
> >the user "Are you REALLY sure you want to install onto the <foo>
> >filesystem on /dev/wherever?". That way people CAN force installation
> >onto non-standard media, but by default we should not do that.
> >
> >Sound reasonable? I'm looking at the code right now to see where to
> >plug in the check.
> 
> The best place to make this work _seems_ to be in
> partman/partman-basicfilesystems/finish.d/check_basicfilesystems. Any
> basic filesystems should not be allowed on /, /usr, /tmp, var...

I'm not sure; basic filesystems per partman are ext2, swap, and FAT. I
don't think we want to be that restrictive, and I don't think
partman-basicfilesystems should have to have knowledge of ReiserFS, XFS,
JFS, or whatever either.

Maybe partman-target or something?

-- 
Colin Watson                                  [cjwatson@flatline.org.uk]



Reply to: