Bug#237921: marked as done (discover: Typo in message, and useless message duplication)
Your message dated Thu, 25 Mar 2004 00:47:03 -0500
with message-id <E1B6Nhn-0006fy-00@newraff.debian.org>
and subject line Bug#237921: fixed in discover1 1.5-7
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 14 Mar 2004 10:15:54 +0000
>From pere@gigs.hungry.com Sun Mar 14 02:15:54 2004
Return-path: <pere@gigs.hungry.com>
Received: from 217-13-7-10.dd.nextgentel.com (minerva.hungry.com) [217.13.7.10]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1B2Sew-0004WZ-00; Sun, 14 Mar 2004 02:15:54 -0800
Received: from pere by minerva.hungry.com with local (Exim 3.35 #1 (Debian))
id 1B2SeO-0000Ks-00; Sun, 14 Mar 2004 11:15:20 +0100
To: submit@bugs.debian.org
Subject: discover: Typo in message, and useless message duplication
From: Petter Reinholdtsen <pere@hungry.com>
Message-Id: <[🔎] E1B2SeO-0000Ks-00@minerva.hungry.com>
Sender: Petter Reinholdtsen <pere@gigs.hungry.com>
Date: Sun, 14 Mar 2004 11:15:20 +0100
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_12
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_12
X-Spam-Level:
Package: discover
Version: 1.5-2
Tags: patch i18n
While translating discover, I noticed a typo in one of the english
messages. "Cant'" should read "Can't". I also discovered that this
message was almost identical to another message to be translated.
Checking the code, I notice that it is no use having both messages.
Here is a patch fixing the typo and removing the redundant message.
Index: lib/calls.c
===================================================================
RCS file: /cvsroot/pkg-discover/discover1/lib/calls.c,v
retrieving revision 1.1.1.1
diff -u -3 -p -u -r1.1.1.1 calls.c
--- lib/calls.c 31 Dec 2003 00:12:53 -0000 1.1.1.1
+++ lib/calls.c 14 Mar 2004 10:13:56 -0000
@@ -89,9 +89,9 @@ extern int exec_detect_helper(char *path
}/*endif*/
}/*endif*/
if(stat(path, &sb)){
- *err = (char *)my_malloc(strlen(path) +
- strlen(_("Can't run following command: ")) + 1);
- sprintf(*err , _("Cant' run following command: %s"), path);
+ char *msg = _("Can't run following command: ");
+ *err = (char *)my_malloc(strlen(path) + strlen(msg) + 1);
+ sprintf(*err , "%s%s", msg, path);
return 1;
}/*endif*/
execv(path, args);
---------------------------------------
Received: (at 237921-close) by bugs.debian.org; 25 Mar 2004 05:53:11 +0000
>From katie@ftp-master.debian.org Wed Mar 24 21:53:11 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1B6Nnj-0003PA-00; Wed, 24 Mar 2004 21:53:11 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1B6Nhn-0006fy-00; Thu, 25 Mar 2004 00:47:03 -0500
From: David Nusinow <david_nusinow@yahoo.com>
To: 237921-close@bugs.debian.org
X-Katie: $Revision: 1.45 $
Subject: Bug#237921: fixed in discover1 1.5-7
Message-Id: <E1B6Nhn-0006fy-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Thu, 25 Mar 2004 00:47:03 -0500
Delivered-To: 237921-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_12
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-1.3 required=4.0 tests=BAYES_00,FORGED_YAHOO_RCVD,
HAS_BUG_NUMBER autolearn=no version=2.60-bugs.debian.org_2004_03_12
X-Spam-Level:
Source: discover1
Source-Version: 1.5-7
We believe that the bug you reported is fixed in the latest version of
discover1, which is due to be installed in the Debian FTP archive:
discover1-udeb_1.5-7_i386.udeb
to pool/main/d/discover1/discover1-udeb_1.5-7_i386.udeb
discover1_1.5-7.diff.gz
to pool/main/d/discover1/discover1_1.5-7.diff.gz
discover1_1.5-7.dsc
to pool/main/d/discover1/discover1_1.5-7.dsc
discover1_1.5-7_i386.deb
to pool/main/d/discover1/discover1_1.5-7_i386.deb
libdiscover1-dev_1.5-7_i386.deb
to pool/main/d/discover1/libdiscover1-dev_1.5-7_i386.deb
libdiscover1-pic_1.5-7_i386.deb
to pool/main/d/discover1/libdiscover1-pic_1.5-7_i386.deb
libdiscover1_1.5-7_i386.deb
to pool/main/d/discover1/libdiscover1_1.5-7_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 237921@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
David Nusinow <david_nusinow@yahoo.com> (supplier of updated discover1 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 23 Mar 2004 02:47:49 -0500
Source: discover1
Binary: libdiscover1 discover1 libdiscover1-pic discover1-udeb libdiscover1-dev
Architecture: source i386
Version: 1.5-7
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: David Nusinow <david_nusinow@yahoo.com>
Description:
discover1 - hardware identification system
discover1-udeb - hardware identification library (udeb) (udeb)
libdiscover1 - hardware identification library
libdiscover1-dev - hardware identification library development files
libdiscover1-pic - hardware identification library - static PIC version
Closes: 229437 237921 238038 238186 238599
Changes:
discover1 (1.5-7) unstable; urgency=low
.
* David Nusinow
- Actually include that README.Debian; Closes: #238038
- Make libdiscover1 depend on discover1-data
- discover init script no longer loads ide-scsi for post 2.4 kernels;
Closes: #229437
- discover1-udeb now Provides: discover. This is to allow hwdetect to
depend on discover and have it work for discover1 or 2
- Fix debian/po/POTFILES.in to account for name change
- Translations
- Norwegian nynorsk for debconf. Thanks HÃ¥vard Korsvoll; Closes: #238599
- Italian for program. Thanks Ruggero T.; Closes: #238186
* Petter Reinholdtsen
- Fix typo in message, and avoid useless message
duplication. (Closes: #237921)
Files:
40eb922233f26961dba4f897ca264c84 760 admin optional discover1_1.5-7.dsc
0d317edd340bc9fce15f2fce22e26300 101282 admin optional discover1_1.5-7.diff.gz
5fb5d1a71ea650b4c83ada138efecc80 34178 debian-installer extra discover1-udeb_1.5-7_i386.udeb
5214e1fba46bd91eaa86199225a59568 70212 admin optional discover1_1.5-7_i386.deb
b68376f5d433295ceb9bfd70613acafa 80736 libs optional libdiscover1_1.5-7_i386.deb
5369c67de734355ea1a7d031237e5486 60960 libdevel optional libdiscover1-dev_1.5-7_i386.deb
758a32a3c36cc7ec5af1be2828660ab2 59876 libs extra libdiscover1-pic_1.5-7_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAYmx32tp5zXiKP0wRAn6cAKCY0nzeZvkyFvq2oamaaBzTY2GHFgCguEfc
B0UsDfWe8HBamCFk0r0jXbY=
=8Vnw
-----END PGP SIGNATURE-----
Reply to: