[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#237921: discover: Typo in message, and useless message duplication



Package: discover
Version: 1.5-2
Tags:    patch i18n

While translating discover, I noticed a typo in one of the english
messages.  "Cant'" should read "Can't".  I also discovered that this
message was almost identical to another message to be translated.
Checking the code, I notice that it is no use having both messages.
Here is a patch fixing the typo and removing the redundant message.

Index: lib/calls.c
===================================================================
RCS file: /cvsroot/pkg-discover/discover1/lib/calls.c,v
retrieving revision 1.1.1.1
diff -u -3 -p -u -r1.1.1.1 calls.c
--- lib/calls.c 31 Dec 2003 00:12:53 -0000      1.1.1.1
+++ lib/calls.c 14 Mar 2004 10:13:56 -0000
@@ -89,9 +89,9 @@ extern int exec_detect_helper(char *path
       }/*endif*/
     }/*endif*/
     if(stat(path, &sb)){
-      *err = (char *)my_malloc(strlen(path) +
-                        strlen(_("Can't run following command: ")) + 1);
-      sprintf(*err , _("Cant' run following command: %s"), path);
+      char *msg = _("Can't run following command: ");
+      *err = (char *)my_malloc(strlen(path) + strlen(msg) + 1);
+      sprintf(*err , "%s%s", msg, path);
       return 1;
     }/*endif*/
     execv(path, args);



Reply to: