[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#234130: marked as done (wget doesn't handle empty *_proxy)



Your message dated Mon, 08 Mar 2004 12:17:07 -0500
with message-id <E1B0ONH-0006FU-00@newraff.debian.org>
and subject line Bug#234130: fixed in busybox-cvs 20040306-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Feb 2004 22:57:24 +0000
>From pelle@dsv.su.se Sat Feb 21 14:57:24 2004
Return-path: <pelle@dsv.su.se>
Received: from smtp1.su.se [130.237.162.112] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Aug3o-0005DE-00; Sat, 21 Feb 2004 14:57:24 -0800
Received: from localhost (smtp1.su.se [127.0.0.1])
	by smtp1.su.se (Postfix) with ESMTP id 0891238E60
	for <submit@bugs.debian.org>; Sat, 21 Feb 2004 23:56:57 +0100 (CET)
Received: from smtp1.su.se ([127.0.0.1])
 by localhost (smtp1.su.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
 id 05774-03 for <submit@bugs.debian.org>;
 Sat, 21 Feb 2004 23:56:56 +0100 (CET)
Received: from unni.dsv.su.se (unni.dsv.su.se [130.237.161.27])
	by smtp1.su.se (Postfix) with ESMTP id 58F5A38DD9
	for <submit@bugs.debian.org>; Sat, 21 Feb 2004 23:56:54 +0100 (CET)
Received: from triton.dsv.su.se (triton.dsv.su.se [130.237.177.14])
	by unni.dsv.su.se (Postfix) with SMTP id 43A8F8B392
	for <submit@bugs.debian.org>; Sat, 21 Feb 2004 23:56:54 +0100 (CET)
Received: by triton.dsv.su.se (sSMTP sendmail emulation); Sat, 21 Feb 2004 23:56:54 +0100
From: "Per Olofsson" <pelle@dsv.su.se>
Date: Sat, 21 Feb 2004 23:56:54 +0100
To: submit@bugs.debian.org
Subject: choose-mirror: fails without proxy
Message-ID: <20040221225654.GA26743@dsv.su.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1i
X-Virus-Scanned: by amavisd-new at su.se
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_02_18 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no 
	version=2.60-bugs.debian.org_2004_02_18
X-Spam-Level: 

Package: choose-mirror
Severity: important
Tags: patch

Hi,

choose-mirror fails if I don't select a proxy because busybox wget
doesn't handle an empty http_proxy variable (it has to be
undefined). I had to make the following change:

Index: retriever/choose-mirror/choose-mirror.c
===================================================================
RCS file: /cvsroot/d-i/debian-installer/retriever/choose-mirror/choose-mirror.c,v
retrieving revision 1.22
diff -u -r1.22 choose-mirror.c
--- retriever/choose-mirror/choose-mirror.c	19 Feb 2004 15:53:51 -0000	1.22
+++ retriever/choose-mirror/choose-mirror.c	21 Feb 2004 22:37:23 -0000
@@ -307,7 +307,7 @@
 		debconf_get(debconf, dir);
 		directory = strdup(debconf->value);
 	
-		if ( NULL == proxy )
+		if ( NULL == proxy || strlen(proxy) == 0 )
 			asprintf(&command, "wget -q %s://%s%s%s/Release -O - | grep ^Suite: | cut -d' ' -f 2",
 		                   protocol, hostname, directory,
 				   "dists/" PREFERRED_DISTRIBUTION);


-- 
Pelle

---------------------------------------
Received: (at 234130-close) by bugs.debian.org; 8 Mar 2004 17:23:07 +0000
>From katie@ftp-master.debian.org Mon Mar 08 09:23:07 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1B0OT5-0004q2-00; Mon, 08 Mar 2004 09:23:07 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1B0ONH-0006FU-00; Mon, 08 Mar 2004 12:17:07 -0500
From: Bastian Blank <waldi@debian.org>
To: 234130-close@bugs.debian.org
X-Katie: $Revision: 1.44 $
Subject: Bug#234130: fixed in busybox-cvs 20040306-1
Message-Id: <E1B0ONH-0006FU-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Mon, 08 Mar 2004 12:17:07 -0500
Delivered-To: 234130-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_08 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=no 
	version=2.60-bugs.debian.org_2004_03_08
X-Spam-Level: 

Source: busybox-cvs
Source-Version: 20040306-1

We believe that the bug you reported is fixed in the latest version of
busybox-cvs, which is due to be installed in the Debian FTP archive:

busybox-cvs-floppy-udeb_20040306-1_i386.udeb
  to pool/main/b/busybox-cvs/busybox-cvs-floppy-udeb_20040306-1_i386.udeb
busybox-cvs-static_20040306-1_i386.deb
  to pool/main/b/busybox-cvs/busybox-cvs-static_20040306-1_i386.deb
busybox-cvs-udeb_20040306-1_i386.udeb
  to pool/main/b/busybox-cvs/busybox-cvs-udeb_20040306-1_i386.udeb
busybox-cvs_20040306-1.diff.gz
  to pool/main/b/busybox-cvs/busybox-cvs_20040306-1.diff.gz
busybox-cvs_20040306-1.dsc
  to pool/main/b/busybox-cvs/busybox-cvs_20040306-1.dsc
busybox-cvs_20040306-1_i386.deb
  to pool/main/b/busybox-cvs/busybox-cvs_20040306-1_i386.deb
busybox-cvs_20040306.orig.tar.gz
  to pool/main/b/busybox-cvs/busybox-cvs_20040306.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 234130@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Blank <waldi@debian.org> (supplier of updated busybox-cvs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 23 Feb 2004 13:22:38 +0100
Source: busybox-cvs
Binary: busybox-cvs-static busybox-cvs busybox-cvs-udeb busybox-cvs-floppy-udeb
Architecture: source i386
Version: 20040306-1
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Bastian Blank <waldi@debian.org>
Description: 
 busybox-cvs - Tiny utilities for small and embedded systems
 busybox-cvs-floppy-udeb - Tiny utilities for the debian-installer floppy images (udeb)
 busybox-cvs-static - Standalone rescue shell with tons of builtin utilities
 busybox-cvs-udeb - Tiny utilities for the debian-installer (udeb)
Closes: 231994 234130
Changes: 
 busybox-cvs (20040306-1) unstable; urgency=low
 .
   * New CVS version
     - Fix directory header in ls. (closes: #231994)
     - wget checks for empty *_proxy. (closes: #234130)
   * debian/config-*:
     - Update.
Files: 
 b9ec9577c045ec741d5a2e14a487bcb9 793 - optional busybox-cvs_20040306-1.dsc
 2fca05e675f94187cc2880dab45bab4c 1321054 - optional busybox-cvs_20040306.orig.tar.gz
 5bab68292ef4eeee78ba9cbd31b227b6 141990 - optional busybox-cvs_20040306-1.diff.gz
 a9d96e50e21b8c25984f2a1f46bf60ca 663310 shells optional busybox-cvs-static_20040306-1_i386.deb
 495bf0192eb239da33d65e30eed8b985 124092 utils optional busybox-cvs_20040306-1_i386.deb
 f624f029aaffbc91c567d84f7ce50ed9 135978 debian-installer extra busybox-cvs-udeb_20040306-1_i386.udeb
 f23c25b04951ee22fa021220e3780bb3 59064 debian-installer extra busybox-cvs-floppy-udeb_20040306-1_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iEYEARECAAYFAkBMpG4ACgkQLkAIIn9ODhHLjQCgoXYghS5NNenRkrGNMfypkpe/
YAMAoJjcwc45IOjAdDlnmAJMyFWa0FZ3
=mdqw
-----END PGP SIGNATURE-----



Reply to: