[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#217503: Evil autopartkit should _NEVER_ _NEVER_ try to overwrite an unknown partition table



On Sun, Oct 26, 2003 at 02:17:37AM +0200, Goswin von Brederlow wrote:

> > This should never never never happen like that, and the whole partition
> > and disk touching thingy is utterly broken as is.

> > It is also not only pegasos related, but will break on m68k/amiga as
> > well as ppc/amiga, as well as all the not yet supported by libparted
> > partition schemes.

> > I see two solutions to this :

> >   1) an NMU of libparted including my amiga patches, which are sitting
> >   in the BTS since almost a month now. This is only a partial solution
> >   though, as we would need to add at least probing code for _every_
> >   partition scheme around (not all that difficult to do). An upload of a
> >   new libparted may mean a recompilation of all the libparted using
> >   binaries, not sure though, it should not happen, as i don't modify the
> >   external representation, but ...

> >   2) Some more rationale chosing of partitioning scheme based on
> >   arch/subarch detection. I notice that partitioner was first tried and
> >   failed, and then it got on to propose to mount partitions and such,
> >   and then it went on to autopartkit. This is broken. One thing that can
> >   be checked is, that despite libparted not recognizing the partition
> >   table type, the kernel _DOES_ know about it, so it should detect it
> >   and warn the user about this in big flashing letters. And something
> >   more flashy than the usual "Are you sure you want to erase this disk"
> >   thingy, since we _know_ that autopartkit is going to write over the
> >   existing partition table.

> 3) Get rid of the autopartition alltogether. Its severly broken for
> anything but "I'm such a stupid user but I only want one linux", which
> kind of excludes itself. People not able to partition themself usually
> want to keep their windows.

You seem to be rather arrogantly overlooking the "I have five of these
machines to build this week and partitions are so far down on my list of
things to configure that I'll scream if I have to see cfdisk one more
time" group.  This is not a question of not being able to partition,
it's a question of by-hand partitioning being a waste of time for a
sizable number of users.

With appropriate warnings about the destructive nature of partitioning,
I believe the autopartitioner will be very useful.

-- 
Steve Langasek
postmodern programmer

Attachment: signature.asc
Description: Digital signature


Reply to: