Bug#216433: marked as done (anna: Do not handle new kernel module udebs properly)
Your message dated Sun, 19 Oct 2003 12:17:09 -0400
with message-id <E1ABGEv-0004gN-00@auric.debian.org>
and subject line Bug#216433: fixed in anna 0.039
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 18 Oct 2003 19:03:40 +0000
>From pere@gigs.hungry.com Sat Oct 18 14:03:38 2003
Return-path: <pere@gigs.hungry.com>
Received: from 217-13-7-8.dd.nextgentel.com (minerva.hungry.com) [217.13.7.8]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AAwMU-0004ri-00; Sat, 18 Oct 2003 14:03:38 -0500
Received: from pere by minerva.hungry.com with local (Exim 3.35 #1 (Debian))
id 1AAwMO-0007uE-00; Sat, 18 Oct 2003 21:03:32 +0200
To: submit@bugs.debian.org
Subject: anna: Do not handle new kernel module udebs properly
From: Petter Reinholdtsen <pere@hungry.com>
Message-Id: <[🔎] E1AAwMO-0007uE-00@minerva.hungry.com>
Sender: Petter Reinholdtsen <pere@gigs.hungry.com>
Date: Sat, 18 Oct 2003 21:03:32 +0200
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-9.4 required=4.0
tests=BAYES_01,HAS_PACKAGE,PATCH_UNIFIED_DIFF
autolearn=ham version=2.53-bugs.debian.org_2003_10_18
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_10_18 (1.174.2.15-2003-03-30-exp)
Package: anna
Version: 0.038
Severity: serious
Tag: d-i patch
The current anna implementation have special code to detect kernel
module udebs, and make sure to only load modules for the running
kernel version. This code assumes that all kernel module udebs are
named like this: foo-modules-XYZ-udeb
This is no longer true on i386, as the udebs are named
'foo-modules-XYZ-di' instead.
The code in question is in udeb_kernel_version(), returning the
version string for kernel module udebs, and NULL for all other
packages.
The problem is serious, as the missing modules make other parts of the
installation fail. The assumtion of hw-detect-full, that all
available kernel modules would be loaded after anna is finished, no
longer hold true, and for example autopartkit is now unable to load
lvm-mod before it starts.
I suspect this code might fix the problem, but am not too sure, so I
submit it as a bug instead of commiting it myself.
--- util.c.~1.22.~ Sun Oct 12 23:15:38 2003
+++ util.c Sat Oct 18 21:01:16 2003
@@ -247,7 +247,7 @@
}
/*
- * Simply return the XYZ in foo-modules-XYZ-udeb
+ * Simply return the XYZ in foo-modules-XYZ-udeb and foo-modules-XYZ-di
* Returns NULL if the match fails
* FIXME: Should we cross-check against the package version?
*/
@@ -263,9 +263,11 @@
if ((t1 = strstr(name, "-modules-")) == NULL)
return NULL;
t1 += sizeof("-modules-") - 1;
- if ((t2 = strstr(t1, "-udeb")) == NULL)
+ if ((t2 = strstr(t1, "-udeb")) == NULL ||
+ (t2 = strstr(t1, "-di")) == NULL)
return NULL;
- if (t2[sizeof("-udeb") - 1] != '\0')
+ if (t2[sizeof("-udeb") - 1] != '\0' &&
+ t2[sizeof("-di") - 1] != '\0' &&)
return NULL;
t2 = di_stradup(t1, t2 - t1);
return t2;
---------------------------------------
Received: (at 216433-close) by bugs.debian.org; 19 Oct 2003 16:23:29 +0000
>From katie@auric.debian.org Sun Oct 19 11:23:29 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1ABGL2-0005Ce-00; Sun, 19 Oct 2003 11:23:29 -0500
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
id 1ABGEv-0004gN-00; Sun, 19 Oct 2003 12:17:09 -0400
From: Petter Reinholdtsen <pere@debian.org>
To: 216433-close@bugs.debian.org
X-Katie: $Revision: 1.42 $
Subject: Bug#216433: fixed in anna 0.039
Message-Id: <E1ABGEv-0004gN-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Sun, 19 Oct 2003 12:17:09 -0400
Delivered-To: 216433-close@bugs.debian.org
Source: anna
Source-Version: 0.039
We believe that the bug you reported is fixed in the latest version of
anna, which is due to be installed in the Debian FTP archive:
anna_0.039.dsc
to pool/main/a/anna/anna_0.039.dsc
anna_0.039.tar.gz
to pool/main/a/anna/anna_0.039.tar.gz
anna_0.039_i386.udeb
to pool/main/a/anna/anna_0.039_i386.udeb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 216433@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated anna package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 19 Oct 2003 17:59:25 +0200
Source: anna
Binary: anna
Architecture: source i386
Version: 0.039
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description:
anna - Load installer modules (udeb)
Closes: 216433
Changes:
anna (0.039) unstable; urgency=low
.
* Christian Perrier
- Update French translation.
* KÄ?stutis BiliÅ«nas
- Add Lithuanian (lt.po) translation.
* Matt Kraai
- Use the error template type for errors.
- Handle kernel module packages that end in -di (Closes: #216433).
* Petter Reinholdtsen
- Add myself as uploader.
Files:
e364a59e235b0284247b6eee3110cb03 684 debian-installer standard anna_0.039.dsc
c43e5c6e10a0c7ea742a58fa83cdcf70 68989 debian-installer standard anna_0.039.tar.gz
08298bbdad7d0142c5f9663d4635b02f 14574 debian-installer standard anna_0.039_i386.udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQE/krWD20zMSyow1ykRAnDbAKC+U4H03NqN2wyAb8lsHXU/PzODNgCePVUB
vgYBgJVzUBH75SwbbDZZP8s=
=5Ii6
-----END PGP SIGNATURE-----
Reply to: