[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#213725: marked as done (set title for package being configured)



Your message dated Sun, 19 Oct 2003 12:17:51 -0400
with message-id <E1ABGFb-0004jX-00@auric.debian.org>
and subject line Bug#213725: fixed in main-menu 0.045
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 2 Oct 2003 09:50:48 +0000
>From kraai@lafn.org Thu Oct 02 04:50:47 2003
Return-path: <kraai@lafn.org>
Received: from host-66-81-30-180.rev.o1.com (ftbfs.org) [66.81.30.180] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1A506g-0002ml-00; Thu, 02 Oct 2003 04:50:47 -0500
Received: from kraai by catalunya with local (Exim 3.36 #1 (Debian))
	id 1A508E-000100-00
	for <submit@bugs.debian.org>; Thu, 02 Oct 2003 02:52:22 -0700
Date: Thu, 2 Oct 2003 02:52:22 -0700
From: Matt Kraai <kraai@alumni.cmu.edu>
To: submit@bugs.debian.org
Subject: set title for package being configured
Message-ID: <[🔎] 20031002095222.GA3826@ftbfs.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.4i
Sender: Matt Kraai <kraai@lafn.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0
	tests=BAYES_30,HAS_PACKAGE
	version=2.53-bugs.debian.org_2003_10_1
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_10_1 (1.174.2.15-2003-03-30-exp)

Package: main-menu
Version: 0.040
Tags: d-i

main-menu should set the title for the package being configured.

In order to do so for the packages that are depended on, I think
we need to add a prewalkfunc callback to di_config_package.

The following patch will set the title for the main-menu entry,
though.

Index: main-menu.c
===================================================================
RCS file: /cvs/debian-boot/debian-installer/main-menu/main-menu.c,v
retrieving revision 1.91
diff -u -c -r1.91 main-menu.c
cvs server: conflicting specifications of output style
*** main-menu.c	2 Oct 2003 03:38:35 -0000	1.91
--- main-menu.c	2 Oct 2003 09:42:43 -0000
***************
*** 421,430 ****
  }
  
  int do_menu_item(struct package_t *p) {
! 	char *configcommand;
  	int ret = 0;
  
  	di_logf("Menu item '%s' selected", p->package);
  
  	if (p->status == installed) {
  		/* The menu item is already configured, so reconfigure it. */
--- 421,438 ----
  }
  
  int do_menu_item(struct package_t *p) {
! 	struct debconfclient *debconf;
! 	char *configcommand, *title;
  	int ret = 0;
  
  	di_logf("Menu item '%s' selected", p->package);
+ 
+ 	debconf = debconfclient_new();
+ 	asprintf(&title, "debian-installer/%s/title", p->package);
+ 	if (debconf_settitle(debconf, title))
+ 		di_logf("Unable to set title for %s.", p->package);
+ 	free(title);
+ 	debconfclient_delete(debconf);
  
  	if (p->status == installed) {
  		/* The menu item is already configured, so reconfigure it. */

-- 
Matty

---------------------------------------
Received: (at 213725-close) by bugs.debian.org; 19 Oct 2003 16:23:38 +0000
>From katie@auric.debian.org Sun Oct 19 11:23:38 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1ABGLC-0005Fh-00; Sun, 19 Oct 2003 11:23:38 -0500
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
	id 1ABGFb-0004jX-00; Sun, 19 Oct 2003 12:17:51 -0400
From: Petter Reinholdtsen <pere@debian.org>
To: 213725-close@bugs.debian.org
X-Katie: $Revision: 1.42 $
Subject: Bug#213725: fixed in main-menu 0.045
Message-Id: <E1ABGFb-0004jX-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Sun, 19 Oct 2003 12:17:51 -0400
Delivered-To: 213725-close@bugs.debian.org

Source: main-menu
Source-Version: 0.045

We believe that the bug you reported is fixed in the latest version of
main-menu, which is due to be installed in the Debian FTP archive:

main-menu_0.045.dsc
  to pool/main/m/main-menu/main-menu_0.045.dsc
main-menu_0.045.tar.gz
  to pool/main/m/main-menu/main-menu_0.045.tar.gz
main-menu_0.045_i386.udeb
  to pool/main/m/main-menu/main-menu_0.045_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 213725@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated main-menu package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 19 Oct 2003 18:05:30 +0200
Source: main-menu
Binary: main-menu
Architecture: source i386
Version: 0.045
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description: 
 main-menu  - Debian installer main menu (udeb)
Closes: 213725
Changes: 
 main-menu (0.045) unstable; urgency=low
 .
   * Christian Perrier
     - Improve French translation.
   * Matt Kraai
     - Set the title before configuring a package (Closes: #213725).
   * KÄ?stutis BiliÅ«nas
     - Add Lithuanian (lt.po) translation.
   * Claus Hindsgaul
     - Actually include Danish translation (da.po) to CVS.
   * Petter Reinholdtsen
     - Removed Tollef Fog Heen as uploader.  He haven't touched the package
       for a long time.
     - Added myself as uploader.
Files: 
 713c47d7393482e7d987288dd8d798c8 744 debian-installer standard main-menu_0.045.dsc
 4e857c646f5c14403fdd0795213e3638 22567 debian-installer standard main-menu_0.045.tar.gz
 dbc4446ff27a6c3b32549aee4d24b9a9 9870 debian-installer standard main-menu_0.045_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/krZm20zMSyow1ykRAkdgAKDrM7ym8hTVzUh1iMRZvVr+iNOQLwCg3kGD
+7HK86BR+ucfgSQLGicDTBE=
=ZyEz
-----END PGP SIGNATURE-----



Reply to: