[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#202562: marked as done (does not display disk model)



Your message dated Fri, 26 Sep 2003 19:17:20 -0400
with message-id <E1A31pw-0003FY-00@auric.debian.org>
and subject line Bug#202562: fixed in yaboot-installer 0.0.5
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 23 Jul 2003 09:06:55 +0000
>From gaudenz@soziologie.ch Wed Jul 23 04:06:50 2003
Return-path: <gaudenz@soziologie.ch>
Received: from stinky.trash.net [195.134.144.50] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19fFa8-0006Ip-00; Wed, 23 Jul 2003 04:06:44 -0500
Received: from [192.168.0.11] (dclient80-218-8-137.hispeed.ch [80.218.8.137])
	(using SSLv3 with cipher RC4-MD5 (128/128 bits))
	(No client certificate requested)
	by stinky.trash.net (Postfix) with ESMTP id B768D948D4
	for <submit@bugs.debian.org>; Wed, 23 Jul 2003 11:06:19 +0200 (MEST)
Subject: various debconf usage problems
From: Gaudenz Steinlin <gaudenz@soziologie.ch>
To: submit@bugs.debian.org
Content-Type: multipart/mixed; boundary="=-+0oeGaD4yrARHmOfnoWe"
Message-Id: <1058951174.873.34.camel@tigerente>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.3 
Date: 23 Jul 2003 11:06:14 +0200
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-13.3 required=4.0
	tests=BAYES_10,HAS_PACKAGE,PATCH_UNIFIED_DIFF,USER_AGENT_XIMIAN
	autolearn=ham version=2.53-bugs.debian.org_2003_07_20
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_07_20 (1.174.2.15-2003-03-30-exp)


--=-+0oeGaD4yrARHmOfnoWe
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Package: yaboot-installer
Version: 0.0.4
Severity: grave
Tags: patch

All the debconf questions in yaboot-installer are missing priorities in
the calls to debconf->command(debconf, "input", ...).

debconf->value after a "go" is "ok" instead of the selected item. You
have to issue debconf->command(debconf, "get", ...) first.

The patch below fixes these two problems.
some comments:
1. I tried to assign reasonable debconf priorities. 
- Critical for all fatal errors 
- low for the partition selection (one normaly only has 1 bootstrap
partition)
- high for non fatal errors
- medium for the success message, probably this could also be low
because you may assume that it was successful if nothing is shown.

2. I added exit(1); calls to the cases where yabootconfig fails and when
no bootstrap partition is found. I think these failures are fatal and
there is no sense in continuing.

3. debconf substitutions are case sensitive. It has to be called
"devices" instead of "DEVICES" if it's lowercase in the themplate.

4. If the return value of the bootpart selection is used directly as
path to the boot partition, we cannot add descriptions like the disk
model. So I removed this.

gaudenz

--=-+0oeGaD4yrARHmOfnoWe
Content-Disposition: attachment; filename=yaboot-installer.patch
Content-Type: text/x-patch; name=yaboot-installer.patch; charset=iso-8859-1
Content-Transfer-Encoding: 7bit

Index: choose-yaboot-disk.c
===================================================================
RCS file: /cvs/debian-boot/debian-installer/tools/yaboot-installer/choose-yaboot-disk.c,v
retrieving revision 1.4
diff -u -r1.4 choose-yaboot-disk.c
--- choose-yaboot-disk.c	17 Jun 2003 21:36:57 -0000	1.4
+++ choose-yaboot-disk.c	23 Jul 2003 09:04:56 -0000
@@ -181,10 +181,7 @@
 char *build_choice(PedPartition *part) {
 	char *string = NULL;
 
-	asprintf(&string, "%s (Typ: %s)",
-		ped_partition_get_path(part),
-		part->disk->dev->model);
-
+        asprintf(&string, "%s", ped_partition_get_path(part));
 	return(strdup(string));
 }
 
@@ -219,7 +216,7 @@
 		debconf->command(debconf, "fset", "yaboot-installer/wrongmac",
 			"seen", "false", NULL);
 		debconf->command(debconf, "set", "yaboot-installer/wrongmac", "false", NULL);
-		debconf->command(debconf, "input", "yaboot-installer/wrongmac", NULL);
+		debconf->command(debconf, "input", "critical", "yaboot-installer/wrongmac", NULL);
 		debconf->command(debconf, "go", NULL);
 		exit(1);
 	}
@@ -233,7 +230,7 @@
 		debconf->command(debconf, "fset", "yaboot-installer/nopart",
 			"seen", "false", NULL);
 		debconf->command(debconf, "set", "yaboot-installer/nopart", "false", NULL);
-		debconf->command(debconf, "input", "yaboot-installer/nopart", NULL);
+		debconf->command(debconf, "input", "critical", "yaboot-installer/nopart", NULL);
 		debconf->command(debconf, "go", NULL);
 		exit(1);
 	}
@@ -243,7 +240,7 @@
 		debconf->command(debconf, "fset", "yaboot-installer/noroot",
 			"seen", "false", NULL);
 		debconf->command(debconf, "set", "yaboot-installer/noroot", "false", NULL);
-		debconf->command(debconf, "input", "yaboot-installer/noroot", NULL);
+		debconf->command(debconf, "input", "critical", "yaboot-installer/noroot", NULL);
 		debconf->command(debconf, "go", NULL);
 		exit(1);
 	}
@@ -266,18 +263,20 @@
 
 	/* ask for boot partition */
 	debconf->command(debconf, "subst", "yaboot-installer/bootdev",
-		"DEVICES", choices, NULL);
+		"devices", choices, NULL);
 	debconf->command(debconf, "fset", "yaboot-installer/bootdev",
 		"seen", "false", NULL);
 	debconf->command(debconf, "set", "yaboot-installer/bootdev", "false", NULL);
-	debconf->command(debconf, "input", "yaboot-installer/bootdev", NULL);
+	debconf->command(debconf, "input", "low", "yaboot-installer/bootdev", NULL);
 	debconf->command(debconf, "go", NULL);
+	debconf->command(debconf, "get", "yaboot-installer/bootdev", NULL);
 	if(strcmp(debconf->value, "") == 0) {
 		debconf->command(debconf, "fset", "yaboot-installer/nopart",
 			"seen", "false", NULL);
 		debconf->command(debconf, "set", "yaboot-installer/nopart", "false", NULL);
-		debconf->command(debconf, "input", "yaboot-installer/nopart", NULL);
+		debconf->command(debconf, "input", "critical", "yaboot-installer/nopart", NULL);
 		debconf->command(debconf, "go", NULL);
+                exit(1);
 	}
 
 	/* update the kernel config file */
@@ -286,7 +285,7 @@
 		debconf->command(debconf, "fset", "yaboot-installer/kconferr",
 			"seen", "false", NULL);
 		debconf->command(debconf, "set", "yaboot-installer/kconferr", "false", NULL);
-		debconf->command(debconf, "input", "yaboot-installer/kconferr", NULL);
+		debconf->command(debconf, "input", "high", "yaboot-installer/kconferr", NULL);
 		debconf->command(debconf, "go", NULL);
 	}
 
@@ -296,8 +295,9 @@
 		debconf->command(debconf, "fset", "yaboot-installer/conferr",
 			"seen", "false", NULL);
 		debconf->command(debconf, "set", "yaboot-installer/conferr", "false", NULL);
-		debconf->command(debconf, "input", "yaboot-installer/conferr", NULL);
+		debconf->command(debconf, "input", "critical", "yaboot-installer/conferr", NULL);
 		debconf->command(debconf, "go", NULL);
+                exit(1);
 	}
 	
 	/* running "ybin" */
@@ -306,14 +306,14 @@
 		debconf->command(debconf, "fset", "yaboot-installer/ybinerr",
 			"seen", "false", NULL);
 		debconf->command(debconf, "set", "yaboot-installer/ybinerr", "false", NULL);
-		debconf->command(debconf, "input", "yaboot-installer/ybinerr", NULL);
+		debconf->command(debconf, "input", "critical", "yaboot-installer/ybinerr", NULL);
 		debconf->command(debconf, "go", NULL);
 		return(1);
 	}
 	
 	debconf->command(debconf, "fset", "yaboot-installer/success", "seen", "false", NULL);
 	debconf->command(debconf, "set", "yaboot-installer/success", "false", NULL);
-	debconf->command(debconf, "input", "yaboot-installer/success", NULL);
+	debconf->command(debconf, "input", "medium", "yaboot-installer/success", NULL);
 	debconf->command(debconf, "go", NULL);
 	return(0);
 }

--=-+0oeGaD4yrARHmOfnoWe--


---------------------------------------
Received: (at 202562-close) by bugs.debian.org; 26 Sep 2003 23:24:08 +0000
>From katie@auric.debian.org Fri Sep 26 18:24:08 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1A31wV-0001RV-00; Fri, 26 Sep 2003 18:24:07 -0500
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
	id 1A31pw-0003FY-00; Fri, 26 Sep 2003 19:17:20 -0400
From: Thorsten Sauter <tsauter@debian.org>
To: 202562-close@bugs.debian.org
X-Katie: $Revision: 1.37 $
Subject: Bug#202562: fixed in yaboot-installer 0.0.5
Message-Id: <E1A31pw-0003FY-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Fri, 26 Sep 2003 19:17:20 -0400
Delivered-To: 202562-close@bugs.debian.org

Source: yaboot-installer
Source-Version: 0.0.5

We believe that the bug you reported is fixed in the latest version of
yaboot-installer, which is due to be installed in the Debian FTP archive:

yaboot-installer_0.0.5.dsc
  to pool/main/y/yaboot-installer/yaboot-installer_0.0.5.dsc
yaboot-installer_0.0.5.tar.gz
  to pool/main/y/yaboot-installer/yaboot-installer_0.0.5.tar.gz
yaboot-installer_0.0.5_powerpc.udeb
  to pool/main/y/yaboot-installer/yaboot-installer_0.0.5_powerpc.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 202562@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thorsten Sauter <tsauter@debian.org> (supplier of updated yaboot-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 26 Sep 2003 23:47:09 +0200
Source: yaboot-installer
Binary: yaboot-installer
Architecture: source powerpc
Version: 0.0.5
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Thorsten Sauter <tsauter@debian.org>
Description: 
 yaboot-installer - Install yaboot on a hard disk (udeb)
Closes: 202562
Changes: 
 yaboot-installer (0.0.5) unstable; urgency=low
 .
   * Gaudenz Steinlin, Thorsten Sauter
     - fixed yaboot.conf generation
     - mount and unmount /target/proc
     - execute ofpath and ybin in chroot
     - fixed isinstallable
     - link against debian-installer
   * Petter Reinholdtsen
     - Add missing priority field to all debconf input requests.
       Added missing debconf get request.  Patch from Gaudenz
       Steinlin. (Closes: #202562)
     - Correct template variable substitution.  Based on patch from
       Gaudenz Steinlin.
   * Alastair McKinstry
     - Move to Standards-Version 3.6.0, converting changelog to UTF-8
   * Javier Fernandez-Sanguino
     - Minor fix to spanish translation
   * Kenshi Muto
     - Added Japanese translation (ja.po)
     - Update ja.po
   * Chris Tillman
     - Update English usage in message templates
   * Jordi Mallach
     - Added Catalan (ca) translation.
   * Michel Grentzinger
     - Update fr.po
Files: 
 1913e9c15a6c89d4b358c9978eda1f2d 684 debian-installer optional yaboot-installer_0.0.5.dsc
 d47996732fa1d0262b884e59b0ddca39 13783 debian-installer optional yaboot-installer_0.0.5.tar.gz
 5d7e8526176b9aa45366569a55e15528 20454 debian-installer optional yaboot-installer_0.0.5_powerpc.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD4DBQE/dMgmlJsl7AdEclIRAhqbAJsEzDRIedqLf/LocfyHQXTYQ3fgcACY7p7H
guxI6u3oNt1/RoSSLLhZcw==
=GELc
-----END PGP SIGNATURE-----



Reply to: