[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#210920: marked as done (main-menu: "Parallel package" detection is broken)



Your message dated Thu, 18 Sep 2003 15:12:31 +0200
with message-id <20030918151231.7474.qmail@mx.mmweg.rwth-aachen.de>
and subject line Finally close this bug
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 14 Sep 2003 18:10:58 +0000
>From sesse@dessverre.samfundet.no Sun Sep 14 13:10:55 2003
Return-path: <sesse@dessverre.samfundet.no>
Received: from dessverre.samfundet.no [129.241.93.53] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19ybKp-0006GN-00; Sun, 14 Sep 2003 13:10:55 -0500
Received: from sesse by dessverre.samfundet.no with local (Exim 3.36 #1 (Debian))
	id 19ybKd-0007FA-00; Sun, 14 Sep 2003 20:10:43 +0200
Content-Type: multipart/mixed; boundary="===============0864120251=="
MIME-Version: 1.0
From: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: main-menu: "Parallel package" detection is broken
X-Mailer: reportbug 2.28
Date: Sun, 14 Sep 2003 20:10:43 +0200
Message-Id: <E19ybKd-0007FA-00@dessverre.samfundet.no>
Sender: "Steinar H. Gunderson" <sesse@dessverre.samfundet.no>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-12.3 required=4.0
	tests=BAYES_30,HAS_PACKAGE,PATCH_UNIFIED_DIFF
	autolearn=ham version=2.53-bugs.debian.org_2003_9_13
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_9_13 (1.174.2.15-2003-03-30-exp)

This is a multi-part MIME message sent by reportbug.

--===============0864120251==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: main-menu
Version: 0.037 (not installed)
Severity: normal
Tags: patch

main-menu is supposed to skip a package if a "parallel package" already
is installed (for instance, grub-installer if lilo-installer is already
installed), but fails to do so. The reason is that the isdefault()
heuristics seem to override the "parallel package" check altogether --
the included patch makes only menutest scripts override the check, while
the usual heuristics (package can be default if it is not configured)
are subject to "parallel package" checking.

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux dessverre 2.4.20-k7 #1 Tue Jan 14 00:29:06 EST 2003 i686
Locale: LANG=C, LC_CTYPE=en_US.ISO8859-1


--===============0864120251==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="main-menu-parallel-fix.diff"

? main-menu-parallel-fix.diff
Index: main-menu.c
===================================================================
RCS file: /cvs/debian-boot/debian-installer/main-menu/main-menu.c,v
retrieving revision 1.82
diff -u -r1.82 main-menu.c
--- main-menu.c	28 Jul 2003 13:16:09 -0000	1.82
+++ main-menu.c	14 Sep 2003 18:07:39 -0000
@@ -51,14 +51,17 @@
 		      (*(struct package_t **)a)->package);
 }
 
-/* Returns true if the given package could be the default menu item. */
+/*
+ * Returns 1 if the given package _should_ be the default menu item (the
+ * menutest script said so), 2 if the given package _could_ be the default
+ * menu item (it is unpacked or half-configured). */
 int isdefault(struct package_t *p) {
 	int check;
 
 	check = check_script(p, "menutest");
 	if (check == -1) {
 		if (p->status == unpacked || p->status == half_configured) {
-			return 1;
+			return 2;
 		}
 		else {
 			return 0;
@@ -104,7 +107,7 @@
 {
 	struct package_t *p, *q;
 	struct list_node *node;
-	int i, cont;
+	int i, cont, def;
 
 	/* Traverse the list, return the first menu item that isn't installed */
 	for (node = list->head; node != NULL; node = node->next) {
@@ -112,7 +115,10 @@
 		if (!p->installer_menu_item || p->status == installed || !check_script(p, "isinstallable"))
 			continue;
 		/* If menutest says this item should be default, make it so */
-		if (isdefault(p))
+		def = isdefault(p);
+		if (def == 0)
+			continue;
+		if (def == 1)
 			return p;
 		cont = 0;
                 /* Check if a "parallel" package is installed

--===============0864120251==--

---------------------------------------
Received: (at 210920-done) by bugs.debian.org; 18 Sep 2003 13:12:43 +0000
>From sebastian.ley@mmweg.rwth-aachen.de Thu Sep 18 08:12:36 2003
Return-path: <sebastian.ley@mmweg.rwth-aachen.de>
Received: from ms-1.rz.rwth-aachen.de (ms-dienst.rz.rwth-aachen.de) [134.130.3.130] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19zyaJ-0003Z2-00; Thu, 18 Sep 2003 08:12:35 -0500
Received: from r220-1 (r220-1.rz.RWTH-Aachen.DE [134.130.3.31])
 by ms-dienst.rz.rwth-aachen.de
 (iPlanet Messaging Server 5.2 HotFix 1.12 (built Feb 13 2003))
 with ESMTP id <0HLE003FAVCW8K@ms-dienst.rz.rwth-aachen.de> for
 210920-done@bugs.debian.org; Thu, 18 Sep 2003 15:12:33 +0200 (MEST)
Received: from relay.RWTH-Aachen.DE ([134.130.3.1])
	by r220-1 (MailMonitor for SMTP v1.2.2 ) ; Thu,
 18 Sep 2003 15:12:32 +0200 (MEST)
Received: from mx.mmweg.rwth-aachen.de
 (mx.mmweg.RWTH-Aachen.DE [134.130.118.4])	by relay.rwth-aachen.de
 (8.12.10/8.12.7-1) with SMTP id h8IDCVsU010246	for
 <210920-done@bugs.debian.org>; Thu, 18 Sep 2003 15:12:31 +0200 (MEST)
Received: (qmail 7477 invoked by alias); Thu, 18 Sep 2003 13:12:31 +0000
Received: (qmail 7469 invoked from network); Thu, 18 Sep 2003 13:12:31 +0000
Received: from coyote.mmweg (134.130.118.117) by hub.mmweg with SMTP; Thu,
 18 Sep 2003 13:12:31 +0000
Date: Thu, 18 Sep 2003 15:12:31 +0200
From: Sebastian Ley <sebastian.ley@mmweg.rwth-aachen.de>
Subject: Finally close this bug
To: 210920-done@bugs.debian.org
Message-id: <20030918151231.7474.qmail@mx.mmweg.rwth-aachen.de>
MIME-version: 1.0
X-Mailer: Ximian Evolution 1.4.4
Content-type: text/plain
Content-transfer-encoding: 7BIT
Delivered-To: 210920-done@bugs.debian.org
X-Spam-Status: No, hits=0.0 required=4.0
	tests=none
	version=2.53-bugs.debian.org_2003_9_16
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_9_16 (1.174.2.15-2003-03-30-exp)

Although I am not in uploaders, I suppose I can safely close this bug.

Sebastian
-- 
PGP-Key: http://www.mmweg.rwth-aachen.de/~sebastian.ley/public.key
Fingerprint: A46A 753F AEDC 2C01 BE6E  F6DB 97E0 3309 9FD6 E3E6




Reply to: