Re: [d-i] Yet Another bug with pre-sprintf malloc:ing
* Martin Sjögren
| I found Yet Another bug with "pre-sprintf" malloc:ing in anna (in
| retriever.c, get_packages), a patch is attached.
thanks, applied. Will try to remember to check in when I get online
again.. :)
| This got me thinking that we could avoid these kind of bugs if we had
| some sort of decent string lib. I think the glib string functions are
| pretty neat and my suggestion is to rip out the ones we need and put in
| libd-i, perhaps under the "namespace" di_str_. Specificially,
| g_strdup_sprintf would solve exactly these kind of problems for us.
can you try to do this, build the library and see how big it gets? If
it's not a too big size increase, I say we go for it.
| Since Debian uses text files a lot, there's a lot of string juggling,
| and that's no fun to do in C unless you've got decent tools...
true.
--
Tollef Fog Heen ,''`.
UNIX is user friendly, it's just picky about who its friends are : :' :
`. `'
`-
Reply to: