Re: Small [patch] (install_depends) and should I apply it?
On Tue, Apr 10, 2001 at 09:35:49AM -0400, Adam Di Carlo wrote:
> Ian Lynagh <igloo@earth.li> writes:
>
> > > Woah woah woah... do *not* start installing packages -- you have to
> > > assume this is being run as a user, not root.
> >
> > Why? I thought the idea was that if they could build boot disks then
> > they could get root via $(ROOTCMD)?
>
> That doesn't mean 'install_depends' is a great idea.
It would have been useful to me (or at least having them all in a list
on one line) which is why I wrote it.
> > and if he says that isn't
> > possible then just print it out in check_depends instead?
>
> Just print it out anyway.
I've attached a patch to do so.
Thanks
Ian
Index: make/checks
===================================================================
RCS file: /cvs/debian-boot/boot-floppies/make/checks,v
retrieving revision 1.4
diff -u -r1.4 checks
--- make/checks 2001/04/08 07:33:39 1.4
+++ make/checks 2001/04/10 15:53:58
@@ -32,12 +32,20 @@
@echo checking boot-floppies dependancies
@perl -e \
'$$_=`sed -n s/^Depends://Ip debian/control`."$(depends_checks)"; \
- $$/="\n\n"; y/,/ /; s/\(.*?\)//g; @M{split()}=""; while (<>) { \
+ $$/="\n\n"; y/,/ /; s/\(.*?\)//g; @M{split()}=""; \
+ while (<>) { \
/^Status: \S+ \S+ installed$$/ms or next; \
delete $$M{$$1} if /^Package: (\S+)/ms; \
delete @M{split(/ *, */,$$1)} if /^Provides: (.+?)$$/ms; \
- } foreach my $$m (keys %M) { print " didn'\''t find $$m\n" } \
- exit 1 if %M' /var/lib/dpkg/status
+ } \
+ foreach my $$m (keys %M) { \
+ print " didn'\''t find $$m\n"; \
+ } \
+ if (%M) { \
+ print "To install missing packages: apt-get install ", \
+ join (" ", keys %M), "\n"; \
+ exit 1; \
+ }' /var/lib/dpkg/status
check_tools:
ifneq ($(tools_checks), )
Reply to: