choose_medium() and choose_archive_dir()

["John H. Robinson, IV" <jhriv@ucsd.edu>]

i'm working on getting rid of the /instmnt messages for
choose_archive_dir(). i have successfully gotten rid of it, and only
some cosmetic issues remain. i will submit my patches, even if i do not
get the cosmetic issues entirely worked out.

the usability issue i have found is this:

the comments for choose_archive_dir indicate that if we use `mounted',
we should be able to look through the root filesystem (the ramdisk, and
all other mounted partitions, including /target) wherease if we chose
``harddisk'' then we should be limited to under /instmnt.

choose_medium.c:209
/*
   text - the message displayed that tells the user what the directory will 
        be used for
   prefix - the default prefix, either "/" for things on the root filesystem
        or "/instmnt/" for things that we mounted for the user

*/
static int choose_archive_dir(char *text, char *prefix)


however, in choose_medium, this comment is ignored, and we are forced to
use /instmnt anyway:

choose_medium.c:14
#define CM_MOUNTPOINT_DIR "/instmnt/"

choose_mdeium.c:1321
    case MED_mounted:
        if (disqtype == problem_report )
          status = choose_archive_dir(
                  _("Please choose the directory where you would like to save the problem report."), CM_MOUNTPOINT_DIR);
        else
          status = choose_archive_dir( _("Please choose the directory where the Debian archive resides."), CM_MOUNTPOINT_DIR);
        if (status == DLG_CANCEL)
            return DLG_CANCEL;
        break;


so my question:
forcing /instmnt seems wrong, since we umount /instmnt at the end of
choose_archive_dir (the exception seems if the user hit cancel).

should we use /target, or / ?
my initial thought was /target, since the only other mounted partitions
would be there (such as, re-using a /var partition, but putting the
drivers.tgz and rescue.bin in there first). the comments seem to imply /

if i don't get any arguments, i am going to use /target

-john