[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch not included in e2fsprogs 1.21.



On Sat, Jun 16, 2001 at 02:28:08PM +0100, Philip Blundell wrote:
> >> (2) The patch is busted (not correct).  The object files being placed
> >>     into the libext2fs_pic.a file are the non-shareable .o files, not
> >>     the PIC .o files.  You need to cd into the elfshared subdirectory to
> >>     get at the PIC files, and the Makefile fragment doesn't do that.
> >
> >Woops... I should really read how vars are used before assuming they
> >hold a full path to files... :}
> 
> Actually, for boot-floppies' purposes it would be slightly better to build 
> the shared library with non-PIC objects.  You may not have done it 
> intentionally but it sounds like you got the right result. :-)

Wouldn't building the .so with non-PIC break quite a few things?

-- 
 -----------=======-=-======-=========-----------=====------------=-=------
/  Ben Collins  --  ...on that fantastic voyage...  --  Debian GNU/Linux   \
`  bcollins@debian.org  --  bcollins@openldap.org  --  bcollins@linux.com  '
 `---=========------=======-------------=-=-----=-===-======-------=--=---'



Reply to: