Re: APUS Debian Boot-Floppies Images and bugs

[Matt Kraai <kraai@debian.org>]

On Mon, May 14, 2001 at 02:21:46PM +0200, Sven LUTHER wrote:
> On Fri, May 11, 2001 at 10:38:07PM +0200, Giorgio Terzi wrote:
> > Bug 1: dbootstrap
> > 
> > The APUS rescue image is MSDOS formatted but in file
> > choose_medium.c from line 34 the code is so:
> >    #if cpu(sparc) || #cpu(powerpc)
> >    const char *fs_type_tab[] = {  "ext2", NULL };
> >    #else
> >    const char *fs_type_tab[] = { "msdos", "ext2", NULL };
> >    #endif
> > as you can understand is impossible for a powerpc machine
> > to load a msdos partition, so i have modified it so:
> >    #if cpu(sparc) || #cpu(powerpc)
> >    const char *fs_type_tab[] = { "msdos", "ext2", NULL };
> >    #else
> >    const char *fs_type_tab[] = { "msdos", "ext2", NULL };
> >    #endif
> 
> I changed this to :
> 
>  #if cpu(sparc)
>  const char *fs_type_tab[] = { "msdos", "ext2", NULL };
>  #else
>  const char *fs_type_tab[] = { "msdos", "ext2", NULL };
>  #endif
> 
> Should work, i think. Does one of the powerpc boot floppies people have
> anything to say about it before i commit ?

Shouldn't this be the following:

#if #cpu(sparc)
const char *fs_type_tab[] = { "ext2", NULL };
#else
const char *fs_type_tab[] = { "msdos", "ext2", NULL };
#endif

The way you wrote it changes the behavior for sparc as well, and
makes the #if totally superfluous.

Matt