Re: [PATCH] nearly successful powerpc build
On Sat, Apr 14, 2001 at 01:36:52AM -0400, james@netcsi.com wrote:
> Hm. It seems that you are right. I noticed the 2.2.18 per se was
> missing, ran 'grep-available' to check for other packages, and only
> 2.2.17 came up, I don't know why. Going through the lists apt
> downloaded by hand revealed ample evidence of 2.2.18pre21 and
> 2.2.19pre17, either of which would have been suitable.
>
> > It should also just be changed to 2.2.19 now. They're in incoming.
It happens :) But try to look a little closer in the future, please.
No one should use anything before 2.2.19 any more, for security
reasons.
> >
> >
> > > # Patch kernel source - FIXME: allow for other patches
> > > cd kernel-source-$kver
> > > -zcat $builddir/usr/src/kernel-patches/powerpc/*.diff.gz \
> > > - | patch -l -s -p1
> > > +# zcat $builddir/usr/src/kernel-patches/powerpc/*.diff.gz \
> > > +# | patch -l -s -p1
> >
> > Deleting lines of code is usually a bad idea.
> >
> > In this case, a very bad idea. This comes from
> > kernel-patch-<ver>-powerpc; I assume it was part of your attempt to go
> > to 2.2.17?
>
> The patch seemed to either have already been applied in the source package,
> or was getting applied twice in the build. I planned to take a closer look
> at it tomorrow. In the meantime it was building with that change and
> freaking out without it.
This is another thing I have to ask you to look closer at. Please
don't commit or post stopgaps like this; they get forgotten about, and
then when I put an important fix in the kernel patch package it'll take
me weeks to figure out why boot floppies are still crashing.
> D'OH! This should teach me to submit patches after midnight. Sheesh. At
> least I remembered to delete it out of the other patch ...
>
> ... I think I'll be adding a config.local now.
Thanks!
--
Daniel Jacobowitz Debian GNU/Linux Developer
Monta Vista Software Debian Security Team
"I am croutons!"
Reply to: