[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

FALSE == 1



I have just spent couple of hours tracking down a problem with a minor patch
I made to the boot-floppies sources. It turns out that I made the assumption
that the macro FALSE would be defined as 0, when in fact dbootstrap.h
defines it as ((int) 1) and the corresponding TRUE definition as ((int) 0).
I have not checked, but could other boot-floppies hackers have also made the
same invalid assumption.

 RCS file:
/cvs/debian-boot/boot-floppies/utilities/dbootstrap/dbootstrap.h,v
 retrieving revision 1.37
 retrieving revision 1.38
 diff -u -r1.37 -r1.38
 --- dbootstrap.h        2000/01/25 07:02:58     1.37
 +++ dbootstrap.h        2000/01/26 21:44:27     1.38
 @@ -4,6 +4,13 @@
  #define USER_SETTINGS_DIR  "/root"
  #define USER_SETTINGS_FILE "/root/dbootstrap_settings"

 +
 +/* Some useful definitions swiped from busybox */
 +#define FALSE   ((int) 1)
 +#define TRUE    ((int) 0)
 +#define BUF_SIZE        8192
 +
 +

 revision 1.38
 date: 2000/01/26 21:44:27;  author: andersee;  state: Exp;  lines: +32 -8
 Cut dbootstrap apart from busybox forever.  It no longer depends
 on busybox internals at all.  Lets keep it that way.

 Also cleaned up and optimized the Makefile a bit.
  -Erik


Nick

----------------------------------------------------------------
Nick Holgate <holgate@debian.org>
GPG key from public servers : Key ID FD9C18AF
Fingerprint = 9DCA EDEA D5C5 57DA 23F3  1A2B 2273 5645 FD9C 18AF




Reply to: