init in busybox (Re: odd -- /var/log/messages and tail in tty3 not working)

[Taketoshi Sano <kgh12351@nifty.ne.jp>]

Hi.

In article <[🔎] 20000122001420.A3013@xmission.com>,
  at Sat, 22 Jan 2000 00:14:21 -0700,
    on Re: odd -- /var/log/messages and tail in tty3 not working,
 Erik Andersen <andersen@xmission.com> writes:

> Excellent!  Thank-you!  I have applied this fix to CVS,

Thanks. I'm glad that I can help you.

I have updated last night, and found your change to add
 openlog() and closelog() before and after syslog().

I think this will fixes the syslogd and logger problems.

BTW, I think another fix should be applied to init.c in busybox.

--- ../../../../../cvs/boot-floppies/utilities/busybox/init.c	Sat Jan 22 20:00:32 2000
+++ ./init.c	Sat Jan 22 20:45:24 2000
@@ -621,8 +621,12 @@
 {
     initAction *a, *b=NULL;
     for( a=initActionList ; a; b=a, a=a->nextPtr) {
-	if (a == action && b != NULL) {
+	if (a == action) {
+          if (b != NULL) {
 	    b->nextPtr=a->nextPtr;
+          } else {
+            initActionList=a->nextPtr;
+	  }
 	    free( a);
 	    break;
 	}


In the current settings in /etc/inittab, this will not 
affect at all. But if the order in /etc/inittab is
changed, and delete_initAction() is given the first action
(or last ? anyway, in the case of if action == initActionList)
as its argument, the result will go in not-intended way.

Please look at this.

-- 
  Taketoshi Sano: <sano@debian.org>,<sano@debian.or.jp>,<kgh12351@nifty.ne.jp>