[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Remove empty GENCONTROL_OPTS definition from blends-dev/Makefile



Hi Ole,


Date: Fri, 13 Apr 2018 10:58:57 +0000
From: Ole Streicher <gitlab@salsa.debian.org>
To: blends-commit@lists.alioth.debian.org
Subject: [Git][blends-team/blends][experimental] Remove empty GENCONTROL_OPTS definition from blends-dev/Makefile

=====================================
devtools/Makefile
=====================================
--- a/devtools/Makefile
+++ b/devtools/Makefile
@@ -30,7 +30,6 @@ VERSION  := $(shell dpkg-parsechangelog -ldebian/changelog | grep Version: | cut
 GENCONTROL := /usr/share/blends-dev/blend-gen-control
 TASKSDIFF := /usr/share/blends-dev/tasks_diff
 DEPENDENCIES_DATA := dependency_data
-GENCONTROL_OPTS := 


That's a pretty sensible explanation for my strange Makefile observation.
I should have spotted this ...

@@ -57,7 +56,7 @@ endif
 all: $(BLEND)-tasks.desc debian/control
 
 debian/control: debian/control.stub debian/changelog tasks/* $(CONFIGCONTROL)
-	$(GENCONTROL) $(GENCONTROL_OPTS) -r $(TARGET_DIST) -S -c -m
+	$(GENCONTROL) -r $(TARGET_DIST) -S -c -m

I admit I would love if the explicite '--udd' option would be kept
as an alternative to read the environment variable.  It is confusing
to have a set of options one specific behaviour is only changable
by an environment variable.

Kind regards

       Andreas.

-- 
http://fam-tille.de


Reply to: