[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [GSoC] blends-gen-control hints (Was: blends-dev, gsoc 2013)



Hi,

another short note after having a look at the patches.  I commited 


commit 890132ad8b9e3cc38e33a079746f93589b9c1d16
Author: Andreas Tille <tille@debian.org>
Date:   Tue Jul 2 14:37:59 2013 +0200

    Add table blends_dependencies_alternatives that should store package dependencies          alternatives to enable creation of metapackages containing dependencies as specified in tasks  files

commit 7693dc7ed78c7fc11daa3bfeca31f88e91074829
Author: Andreas Tille <tille@debian.org>
Date:   Tue Jul 2 14:36:11 2013 +0200

    Read "Avoid" flag from tasks files

commit 7b4f110264323f14e7c9b8af16a9bd4c53a29846
Author: Andreas Tille <tille@debian.org>
Date:   Tue Jul 2 14:34:39 2013 +0200

    Enable adding "Avoid" key in tasks files


which is harmless - I'll wait with changing the importer significantly
until I had a chance to do real tests.  Please note that you need to
GRANT guest read permissions after creating new tables (I just injected
it this way).

Kind regards

      Andreas.

On Mon, Jul 01, 2013 at 03:27:17PM +0300, Emmanouil Kiagias wrote:
> Hello Andreas,
> 
> This my first attempt to write small patches for udd[0](for the changes we
> were discussing) one for blends_metadata_gatherer.py and one for setup.sql
> (I have attached the two corresponding files).
> I added an extra table blends_dependencies_alternatives(i did not think of
> any other table name or fields name):
> 
> -------------------------------------------------------------
> blend         |      task         |     alternatives
> -------------------------------------------------------------
> blendname |      taskname |     package1 | package2 | package3 ..
> 
> I added in blends_metadata_gatherer.py to also include the avoid
> packages(in order to keep a list of the excluded packages per task as
> current blend-gen-control, if you think we do not this you can remove it).
> Also I have to note that I added into "my_config" of
> blends_metadata_gatherer.py a 'table-alternatives' entry which should
> provide the name "blends_dependencies_alternatives" of the new table when
> it's needed in the code(I imitated the way you use the other configs you
> already have).
> 
> I do not know if these were the changes you had in mind when thinking about
> adding the extra table to handle to packages' alternatives. In cas e you
> don't agree with something let me know and I will change it(or rewrite the
> code if I am in a completely wrong direction).
> 
> Kind regards
> 
> Emmanouil
> 
> [0] git://anonscm.debian.org/collab-qa/udd.git




-- 
http://fam-tille.de


Reply to: