[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [GSoC] Check architectures



Hello Andreas,

I usually have some fun with trying unusal options and thus tested

   blend-gen-control --architecture xyz ...

which is properly handled by

   get_available_architectures(self)

I was happy to see this test because it is flexible enough to cope with
any new arch or those we are possibly droping in the future.  The only
change I would like to suggest is

$ git diff
diff --git a/blend-gen-control b/blend-gen-control
index 1a81aa1..7e28ff0 100755
--- a/blend-gen-control
+++ b/blend-gen-control
@@ -86,7 +86,7 @@ class UDD_connector:
         """
         It queries the UDD and returns a list with all the available Debian architectures
         """
-        query = "select distinct architecture from packages"
+        query = "select distinct architecture from packages where architecture != 'all'"

         self.__execute_query(query)

Ok I made that change, thanks for your fast feedback :-)

I think I got the reason of the change, I will try to use proper wording: generating a control file for 'all' architecture(as I was doing previously) it will contain only the architecture independent packages which anyway we already include them in our query: blends-gsoc/sql/blendsd. And also in our case we want to create architecture dependent metapackages and independent. right?

Kind regards

Emmanouil

Reply to: