[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#489811: cdd-dev: Should support enhances and test-* tasksel headers

[Andreas Tille]
> I guess I should apply the patch modulo the Debug line
> "Testheader". ;-) I can confirm that the Enhances line from
> lang-nb-desktop was successfully propagated to debian-edu-tasks.desc
> (there is no other occurrence of Enhances) and thus I think I'll
> upload the new cdd-dev version.  You should adapt your versioned
> build-depends in debian-edu if you want to make sure that the
> feature is really used.

Thank you.  Done.

I noticed one thing while testing the new feature.  I suspect we do
not want to generate metapackages (as in entries in debian/control)
for such enhancing packages.  At least, I suspect we should have a way
to avoid generating metapackages for tasks.

Here is a draft patch doing that.

--- /usr/share/cdd-dev/cdd-gen-control  2008-02-07 11:52:38.000000000 +0100
+++ cdd-gen-control     2008-07-08 16:53:00.000000000 +0200
@@ -169,6 +169,7 @@
 sub gen_control {
     my $task;
     for $task (sort keys %taskinfo) {
+        next if (defined $taskinfo{$task}{Enhances});
         print "Package: $task\n";

         my $header;

Not sure if this is the best way to handle it.  Perhaps better to have
a separate task header for this, like the leaf header used to control
tasksel tasks.  What is your view on this?

Happy hacking,
Petter Reinholdtsen

Reply to: