Re: Ruby Package Backports
Daniel Baumann wrote:
> however, then i'll have a look at your packages now... (separat mail)
here we go...
a general note first: some of the orig.tar.gz do not match the ones
available on ftp.debian.org, please make always sure those have the same
md5/sha1 hashes.
ruby-pkg-tools:
* the package is a native package, but you build a non-native one.
please revert.
* you changelog is strange:
- normally, you write something like '* Rebuild for sarge.'
or similar, but not '* Creating changelog entry to set version and
release for backport.'
- the bottom line of a changelog entry should be:
'-- $name <$email> $date' and not '-- <$email> $date'.
the rest of this package is fine.
rake is fine, except for the changelog (same things as with ruby-pkg-tools).
librmagick-ruby:
* same as with changelog of ruby-pkg-tools.
* additionally you /replaced/ the previous changelog entry in the
package, instead of adding your own new one on top of it.
* a minor tipp about style: if you change a build-dependency,
i would keep it in the same 'style' as it was before.
here, you lower 'cdbs (>= 0.4.33)' to 'cdbs (>= 0.4.28-1)'.
i would have lowered it to 'cdbs (>= 0.4.28)'. note that both is
practically the same here, it's just a matter of taste.
the rest of this package is fine.
libpgsql-ruby is fine, except for the changelog (same things as with
ruby-pkg-tools).
libgems-ruby is fine, except for the changelog (same things as with
ruby-pkg-tools).
if you change the things mentioned above in your packages, i'm uploading
them for you.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baumann@panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
Reply to: