Re: salsa-ci build-dependency issue

[Ole Streicher <olebole@debian.org>]

Hi Attila,

Attila Kovacs <attipaci@gmail.com> writes:
> I m having some issues with salsa CI. I have failures on both
> 'test-build-all' and 'test-build-any', because of missing build
> dependencies.

>From the current state, it looks OK now; the only failing task is
the crossbuild one, and this can be ignored for the moment.

> Here are the Build-Depends settings from control:
>
> Build-Depends: debhelper-compat (= 13)
> Build-Depends-Arch: gcc (>= 3.0), gfortran
> Build-Depends-Indep: gcc (>= 3.0), sed (>= 4.1), doxygen (>= 1.9.0)

Minversions are not needed if the current (and maybe older, supported)
version of Debian are affected. gcc is >3.0 since quite a long time, so
this is not needed anymore. I would remove them. Same is for sed and for
doxygen.

A few other things that were found by lintian (warnings):

W: supernovas: description-synopsis-starts-with-article

Just remove the "The" in the start of the short description.

W: supernovas source: no-nmu-in-changelog [debian/changelog:1]

Your name and email addresses should match in debian/control and
debian/changelog. Also, please make the package team maintained by using

Maintainer: Debian Astro Team <debian-astro-maintainers@lists.alioth.debian.org>
Uploaders: Attila Kovacs <attipaci@gmail.com>

(or whatever you prefer as you e-mail address here)

W: supernovas: package-name-doesnt-match-sonames libsupernovas1
W: supernovas-solsys1: package-name-doesnt-match-sonames libsolsys1-1
W: supernovas-solsys2: package-name-doesnt-match-sonames libsolsys2-1

If you have shared libraries, they should be packaged separately in
packages with special file names. Check the Debian policy

https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

for details.

>From the informational tags, I think the following are important:

I: supernovas source: debian-watch-contains-dh_make-template Example
   watch control file for uscan [debian/watch]

Please try to make a working debian/watch file. I could help with that
(depending on how the upstream package marks the versions).

I: supernovas: extra-license-file [usr/share/doc/supernovas/LICENSE]

This file should just not installed in the package, as there is already
the copyright file of Debian which must be complete.

I: supernovas source: out-of-date-standards-version 4.6.0 (released 2021-08-18) (current is 4.6.2)

Lintian is incorrect here: current version is 4.7.0; please update
debian/control accordingly.

I: supernovas: spelling-error-in-binary poointer pointer
   [usr/lib/x86_64-linux-gnu/libsupernovas.so.1]

As you are upstream as well: Fix it there for the next release?

P: supernovas source: trailing-whitespace [debian/control:22]

Please remove the trailing whitespaces in debian/control

Cheers

Ole