[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Siril 1.0.3 is ready for upload



On 6/29/22 6:09 PM, Cyril Richard wrote:
Hello. Looks like it is because this file has also a:
very-long-line-length-in-source-file

And the spec says:
Please note, that very-long-line-length-in-source-file tagged files are likely tagged source-is-missing.

So, usually generated code renders long-length lines (for instance if you see minified javascript code)
and this "hints" that the file probably contains generated code and not the source.
For your case, it is not true

For instance I see:

| P: siril source: very-long-line-length-in-source-file 1002 > 512 [src/tests/photometry_test.c:35]
| P: siril source: very-long-line-length-in-source-file 1377 > 512 [commands_reference.html:203]
| P: siril source: very-long-line-length-in-source-file 1799 > 512 [src/core/command_def.h:124]
| P: siril source: very-long-line-length-in-source-file 546 > 512 [platform-specific/linux/org.free_astro.siril.desktop:49]
| P: siril source: very-long-line-length-in-source-file 654 > 512 [subprojects/librtprocess/README.md:59]
| P: siril source: very-long-line-length-in-source-file 844 > 512 [src/gui/siril3.glade:20128]

In these files, none of that is generated code. It is just that you wrote _really_ long lines into those files.

It is a feature not a bug.

Neither of these. It is only a hint, and should be overridden due to above mentioned reason.

So how can I handle this? I've tested it on my computer with: lintian -I -E --pedantic and I haven't seen the error.

I add in more lintian options to get these.
In my setup,

$ lintian -I --color always --display-info --display-experimental --pedantic

is run by default after sbuild is done building the package and I see the warning/error then. Make sure
that you use the latest version of lintian, though.

--
Best,
Nilesh

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: