Re: Munipack review
Hi Filip,
the problem is now however, that there is already one version 0.5.8 of
the original tarball uploaded, and another upload of an original tarball
with the same version number is impossible. You will need to use a
different (higher) version number.
One more thing: Please "tag" the version in git: use f.e. upstream/0.5.8
for the upstream release and debian/0.5.8-1 for the Debian version. This
helps to link the Debian package to the git. I already did that for the
versions up to now.
Best regards
Ole
Filip Hroch <hroch@physics.muni.cz> writes:
> I'm very sorry, but I forget to commit all changes to
> control files. The version number is the manifestation.
> There is more serious corrections with new features
> and solving CI and unreproducible problems.
>
> Moreover I found problem with using of --exclude-vcs,
> --exclude-vcs-ignores switches of tar which works
> a little bit unexpected way.
>
> I corrected all the problems.
>
> Thank you very much for patience.
> FH
>
>
> On Fri, 2017-07-14 at 12:24 +0200, Ole Streicher wrote:
>> Hi Filip,
>> Filip Hroch <hroch@physics.muni.cz> writes:
>> > I am sorry to disturb your during summer holiday.
>> > It's cold outside so I prepared new upstream
>> > version of Munipack.
>> >
>> > I'm requesting for a review of the code.
>>
>> Uploaded. For the next version, please bring the Standards-Version
>> (currently set to 3.9.8) to the newest version (currently 4.0.0), and
>> check the policy changes whether the package needs an update there:
>>
>> https://www.debian.org/doc/debian-policy/upgrading-checklist.html
>>
>> Also, just curious: Why did you remove the GPL copyright text?
>>
>> Best regards
>>
>> Ole
Reply to: