Re: Bug#846539: ITP: gwcs -- Tools for managing the World Coordinate System of astronomical data
Hi Miguel,
I have a few new issues:
* The tests fail. One reason here is that upstream still uses
"pyasdf", while the name was change to "asdf" (the pyasdf name is
taken now by seismic scientists). See
https://github.com/spacetelescope/asdf/issues/186
for details. Aside from that we need a patch here, please report this
upstream so that they can fix this as well.
There is another failure test_attributes[SkyOffsetFrame], which I
don't understand. Could you clarify the details here with upstream?
_______________________ test_attributes[SkyOffsetFrame] ________________________
frame = 'SkyOffsetFrame'
@pytest.mark.parametrize(('frame'), coord_frames)
def test_attributes(frame):
""" [...]"""
> cel = cf.CelestialFrame(reference_frame=getattr(coord, frame)())
/usr/lib/python2.7/dist-packages/gwcs/tests/test_coordinate_systems.py:91:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
cls = <class 'astropy.coordinates.builtin_frames.skyoffset.SkyOffsetFrame'>
args = (), kwargs = {}
def __new__(cls, *args, **kwargs):
# We don't want to call this method if we've already set up
# an skyoffset frame for this class.
if not (issubclass(cls, SkyOffsetFrame) and cls is not SkyOffsetFrame):
# We get the origin argument, and handle it here.
try:
origin_frame = kwargs['origin']
except KeyError:
> raise TypeError("Can't initialize an SkyOffsetFrame without origin= keyword.")
E TypeError: Can't initialize an SkyOffsetFrame without origin= keyword.
/usr/lib/python2.7/dist-packages/astropy/coordinates/builtin_frames/skyoffset.py:196: TypeError
---------------------------8<-------------------------------------------
* For some reason, the tests are not executed at build time.
* in debian/copyright, the first section has two "Copyright" lines. You
could just indent the second copyright by one space instead.
* The documentation package is empty. To fill it, you should create a
file debian/python-gwcs-doc.docs containing the directory where the
docs are built. Like: "build/html". Also, there should be a file
debian/python-gwcs-doc.doc-base with the documentation metadata:
---------------------------8<-------------------------------------------
Document: python-gwcs
Title: GWCS API documentation
Author: Nadia Dencheva
Section: Science/Astronomy
Abstract: GWCS takes a general approach to WCS. It supports a data model
which includes the entire transformation pipeline from input
coordinates (detector by default) to world coordinates. The goal is
to provide a flexible toolkit which is easily extendible by adding new
transforms and frames.
Format: HTML
Index: /usr/share/doc/python-gwcs-doc/html/index.html
Files: /usr/share/doc/python-gwcs-doc/html/
---------------------------8<-------------------------------------------
The last two issues can also be found with the "lintian" program. Errors
and warnings there should be fixed. If you specify "-E -I --pedantic",
you get also a number of potential issues, which you should check if
they are important.
Best regards
Ole
Miguel de Val-Borro <miguel.deval@gmail.com> writes:
> Thank you very much for your comments. I have corrected those issues
> in the git repository of the gwcs package on alioth:
>
> https://anonscm.debian.org/cgit/debian-astro/packages/gwcs.git
>
> Please let me know if there is anything else that needs to be modified.
>
> Miguel
Reply to: