Re: Bug#846539: ITP: gwcs -- Tools for managing the World Coordinate System of astronomical data
Dear Miguel,
I have checked you package; there are only a few smaller issues. The
largest problem is that debian/copyright is still incomplete: you should
document the licenses of astropy_helpers (even when it is not used
here), and also put some copyright on the packaging files in debian/
(the simplest would be to add yourself to the copyright line of the
first section).
Other points:
* debian/control
- put yourself into "Uploaders", no me
- Make the short descriptions a bit shorter (so that it fits into the
line)
- python3-pywcs should depend on ${python3-depends}
- maybe better use http://gwcs.readthedocs.io as homepage?
* debian/changelog: replace MAINTAINER by your real name. Name + email
should match exactly what is in the "Uploaders" field of debian/control
* Please consider creating a documentation package
* Please consider creating CI tests in debian/tests
The key "Uploaders" may be a bit confusing -- it is just the name (or
the names) who is responsible for a team maintained package. My role is
called "Sponsor" (even if I actually upload the package then...), and
doesn't need to be noted within the package.
The documentation package would be really nice because we want to have
the packages self-contained, and the docs are actually provided with the
source here.
CI tests would help to ensure that the package works on a long term. For
example, python-asdf may be updated at some day, and it would be good to
have an automated check that everything works after the update. In the
simplest cases, this is quite trivial and needs just to create a text
file debian/tests/control, like for astroquery:
https://sources.debian.net/src/astroquery/0.3.4%2Bdfsg-1/debian/tests/control
I will sponsor the package without this, however, once you dealt with
the first points. Just ping me again :-)
Cheers
Ole
On 05.12.2016 00:26, Miguel de Val-Borro wrote:
> Dear Ole,
>
> That sounds great. The GWCS package is ready for review now and is
> available at the git repository on alioth below. Thank you in advance
> for any comments on the package.
>
> https://anonscm.debian.org/cgit/debian-astro/packages/gwcs.git
>
> Miguel
>
> On Fri, Dec 02, 2016 at 08:52:35AM +0100, Ole Streicher wrote:
>> Dear Miguel,
>>
>> would you mind to put the packaging under Debian Astro team maintenance?
>> This would make contributions of others easier, and we would also help
>> you with questions and finally sponsor the package when it is ready.
>>
>> On 01.12.2016 23:56, Miguel de Val-Borro wrote:
>>> * Package name : gwcs
>>> Version : 0.5.1
>>> Upstream Author : Nadia Dencheva <dencheva@stsci.edu>
>>> * URL : https://github.com/spacetelescope/gwcs
>>> * License : BSD-3-Clause
>>> Programming Lang: Python
>>> Description : Tools for managing the World Coordinate System of astronomical data
>>>
>>> GWCS supports a data model which includes the entire transformation pipeline
>>> from input coordinates to world coordinates. The goal of the package is to
>>> provide a flexible toolkit which is easily extendible by adding new transforms
>>> and frames.
>>>
>>> The package will be maintained using a git repository on alioth.
>>
>> The Debian Astro web page is https://blends.debian.org/astro
>>
>> I am forwarding this to our mailing list as well:
>>
>> https://lists.debian.org/debian-astro
>>
>> Best regards
>>
>> Ole
>>
>
Reply to: