[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fwd: Bug#764549: ITP: siril -- Astronomical image processing tool



On Thu, Oct 16, 2014 at 02:13:15PM +0200, Thibaut Paumard wrote:
> Dear Vincent,
> 
> Apparently you chose to make the debian development in the debian branch
> of the git repo. That's fine, but you should set the HEAD of the repo to
> point to that branch instead of master.
> 
> I can't install the dependencies for your package (in unstable).
> libjpeg8-dev cannot be installed together with libtiff5-dev. Note that
> there was a decision to ship libjpeg-turbo instead of libjpeg8:
>   https://lists.debian.org/debian-devel-announce/2014/08/msg00000.html
> 
> Once I removed libjpeg8-dev from the build-deps, I was able to install
> the rest.
> 
> Now on to your troubles:
> 
> Le 16/10/2014 04:05, Vincent Hourdin a écrit :
> > I'm currently unable to build it because I have made a
> > modification in the debian branch to remove the LICENSE file from make
> > install, and debuild detects it and stops.
> 
> You are using source package format version "3.0 (quilt)". The spirit of
> this format is to keep modifications of the upstream sources in
> separated topic patches. You have two solutions:
> 
> 1) My preferred: normal 3.0 (quilt)
> 
> When you need to patch something in the source, create a new patch:
> 
> $ quilt new <name of the patch>
> $ quilt add <files you will patch>
> $ # edit the files
> $ quilt refresh
> $ # there is a recommended step to document the header of the patch
> $ quilt header -e --dep3
> $ # if i remember correctly. Check the manpage.
> 
> Before you commit to git, run:
> 
> $ quilt pop -a
> 
> This reverts your changes. Make sure you do commit the files in
> debian/patches, but not the modified upstream files.
> 
> 2) The "easy" way: single automatic patch
> 
> Just modify the upstream files as you see fit, and tell dpkg-source to
> generate a simple patch file for you. You do that by putting the right
> option in debian/source/options, see the manpage for dpkg-qource.
> 
> Regards, Thibaut.
> 

Thank you all. I have made many changes. Quilt was indeed quite easy and
appropriate.
I'm almost able to build the package now, I have an issue with the
dh_installchangelogs rule that makes the following error at the end of
compilation:
install: cannot change ownership of `debian/siril/usr/share/doc/siril/changelog.Debian': Operation not permitted
dh_installchangelogs: install -o 0 -g 0 -p -m644 debian/changelog debian/siril/usr/share/doc/siril/changelog.Debian returned exit code 1

I'm not sure I make the menu file correctly at all, if found the
documentation quite obscur.
I haven't verified how the icon should be converted yet, but yes it will
be done upstream anyway.

The dependencies are quite a big issue I believe: in unstable
libtiff5-dev conflicts with libjpeg8-dev, in stable libtiff5-dev
conflicts with libopencv-dev that installs the libtiff4-dev, and
libtiff4-dev doesn't have a pkgconfig file. Which version of debian
should the package target? I would say testing or unstable because
running a desktop on stable is quite silly, but I have no other distrib
than stable for testing, not even ubuntu or derivatives.
The dependencies should be libtiff5-dev, any libjpeg*-dev and
libopencv-dev if possible. If not, I would say libtiff is the less
important of the three.

Besides that, I believe that runing lintian and fixing the errors is the
last step I haven't done from what was described in previous e-mails.

Enjoy your sunday,
Vincent


Reply to: