Re: Bug#745609: RFS: eso-midas/13.09pl1.2-1 [ITP] -- European Southern Observatory Munich Image Data Analysis System
- To: debian-astro@lists.debian.org
- Subject: Re: Bug#745609: RFS: eso-midas/13.09pl1.2-1 [ITP] -- European Southern Observatory Munich Image Data Analysis System
- From: Achim Bohnet <ach@mpe.mpg.de>
- Date: Tue, 13 May 2014 17:22 +0200
- Message-id: <[🔎] 6170583.fN8MPFEsBz@allee>
- In-reply-to: <535A4F1C.2070307@liska.ath.cx>
- References: <5357877B.3080305@liska.ath.cx> <alpine.DEB.2.02.1404241912130.14479@jupiter.server.alteholz.net> <535A4F1C.2070307@liska.ath.cx>
On Freitag 25 Apr 2014 14:03:40 Ole Streicher wrote:
[..]
> On 24.04.2014 19:44, Thorsten Alteholz wrote:
[..]
> > Most important
> >
> > install/unix/systems/Linux_alpha/README.linux
> >
> > tells that midas is only for non-commercial usage.
Hi Ole,
Did upstream remove this file? AFAIU if you remove it, and then declare
it DSFG free, that's not the correct procedure ;-)
I tried a source build on latest kubuntu 14.04 and it build successfully.
What I noticed is:
Now running lintian...
E: eso-midas changes: bad-distribution-in-changes-file unstable
W: eso-midas: script-not-executable usr/lib/eso-midas/13SEP/install/unix/systems/A-UX/util/f77
W: eso-midas: script-not-executable usr/lib/eso-midas/13SEP/install/unix/systems/Debian/make_shared
W: eso-midas: script-not-executable usr/lib/eso-midas/13SEP/test/prim/midasparallel
W: eso-midas: script-not-executable usr/lib/eso-midas/13SEP/test/prim/midcheck
W: eso-midas: executable-not-elf-or-script usr/lib/eso-midas/13SEP/test/prim/verify17.prg
W: eso-midas: executable-not-elf-or-script usr/lib/eso-midas/13SEP/test/prim/badfitskeys.mt
N: 3 tags overridden (1 error, 1 warning, 1 info)
Most of (or maybe even all?) the stuff below eso-midas/13SEP/test/ and eso-midas/13SEP/install/ is
not required and should therefore not be in the .deb, right? (Maybe a run make check target
during build?)
As the system readline is used, those file should not be installed:
$ dpkg --contents ../eso-midas_13.09pl1.2+dfsg-1_amd64.deb | grep readline
-rw-r--r-- root/root 9972 2014-05-13 16:01 ./usr/share/man/man3/readline.3.gz
-rw-r--r-- root/root 30472 2013-11-09 11:15 ./usr/lib/eso-midas/13SEP/system/unix/man1/readline.1
-rw-r--r-- root/root 30472 2013-11-09 11:15 ./usr/lib/eso-midas/13SEP/system/unix/manl/readline.l
Doublicate files:
$ dpkg --contents ../eso-midas_13.09pl1.2+dfsg-1_amd64.deb | grep man[1-9]
drwxr-xr-x root/root 0 2014-05-13 16:01 ./usr/share/man/man1/
-rw-r--r-- root/root 1862 2014-05-13 16:01 ./usr/share/man/man1/inmidas.1L.gz
-rw-r--r-- root/root 1023 2014-05-13 16:01 ./usr/share/man/man1/helpmidas.1L.gz
-rw-r--r-- root/root 787 2014-05-13 16:01 ./usr/share/man/man1/gomidas.1L.gz
drwxr-xr-x root/root 0 2014-05-13 16:01 ./usr/share/man/man3/
-rw-r--r-- root/root 9972 2014-05-13 16:01 ./usr/share/man/man3/readline.3.gz
drwxr-xr-x root/root 0 2014-05-13 16:01 ./usr/lib/eso-midas/13SEP/system/unix/man1/
-rw-r--r-- root/root 1533 2013-11-09 11:15 ./usr/lib/eso-midas/13SEP/system/unix/man1/gomidas.1
-rw-r--r-- root/root 30472 2013-11-09 11:15 ./usr/lib/eso-midas/13SEP/system/unix/man1/readline.1
-rw-r--r-- root/root 2077 2013-11-09 11:15 ./usr/lib/eso-midas/13SEP/system/unix/man1/helpmidas.1
-rw-r--r-- root/root 4290 2013-11-09 11:15 ./usr/lib/eso-midas/13SEP/system/unix/man1/inmidas.1
Searching /usr/share/man/man1/*[^19].gz shows that extentions are ssl, x, p (for
perl) ... and L for local install makes no sense IMHO for a .deb pkg. As
inmidas helpmidas and gomidas are pretty unique names, I would suggest to
replace .1L extention of the manpages with just .1
Thx for pkging midas,
Achim
> > You should get a statement from upstream that this is no longer valid
> > and add a comment to debian/copyright (or better let upstream remove
> > that file).
--
To me vi is Zen. To use vi is to practice zen. Every command is
a koan. Profound to the user, unintelligible to the uninitiated.
You discover truth everytime you use it.
-- reddy@lion.austin.ibm.com
Reply to: