Re: [E1000-devel] Supporting platforms with no EEPROM?
Arnaud Patard (Rtp) wrote:
> Riku Voipio <riku.voipio@iki.fi> writes:
>
> Hi,
>>>>>> code in the e1000 driver that deals with the EEPROM and MAC
>>>>>> addresses. Is there any plan for cleanly handling no-EEPROM
>>>>>> platforms, or am I into "undiscovered territory" here? I'm willing
>>>>>> to submit patches once I find a minimally-invasive and robust
>>>>>> solution, but I don't want to reinvent the wheel...
>>> we don't want to support this in the default drivers, but maybe we could
>>> in the kernel with a Kconfig option that defaulted to off.
>> This could be acceptable, we would only turn that option on the iop32x
>> kernel. It's sub-optimal, as some iop32x boards have PCI slots.
>
> I don't know which iop32x configurations are enabled in the default
> iop32x kernel but there are some boards with e1000 which do have the
> eeprom so imho unless you do some kind of runtime detection, I fear
> you'll break theses boards.
Right.
All I want is runtime logic that says, "if I don't have an EEPROM but it looks
like I have a valid MAC address, then continue normally". Jesse is suggesting
that such logic should be conditional at compile time, defaulting to off; Riku
is saying that he'll enable that logic in the iop32x platforms (at least).
b.g.
--
Bill Gatliff
bgat@billgatliff.com
Reply to: