[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#503144: FTBFS on armel: gsf-scan, ** ERROR **: Compilation trouble with endianess.



> > > gsf thinks only vfp enabled arm uses natural endian doubles. However,
> > > eabi does that as well. As anyone using vfp is also using eabi,
> > > the correct change is to switch the define.
> > >
> > > -#if defined(__arm__) && !defined(__vfp__) && (G_BYTE_ORDER ==
> > > G_LITTLE_ENDIAN) 
> > > +#if defined(__arm__) && !defined(__ARM_EABI__) && 
> > > (G_BYTE_ORDER == G_LITTLE_ENDIAN)
>
> This is my/phil blundell's fault.
>
> libgsf was fixed a long time ago - before eabi stuff had any sort of
> plan in Debian. Using __vfp__ seemed like the best test at the time,
> as recommended to me by pb. I'm not sure when you end up with
> __ARM_EABI__ defined but __vfp__ not defined in practice, but I agree
> the change is now correct.

The correct macro is __VFP_FP__. I've no idea where you got __vfp__ from.
Using __ARM_EABI__ will be sufficient for Debian but is not the correct 
solution.

Not that, despite the name, __VFP_FP__ does not imply that VFP hardware is 
being used (This is indicated by __VFP_FP__ && !__SOFTFP__).
It means VFP format doubles are being used (i.e. natural endian ieee).

Paul


Reply to: