Re: Bug#503144: FTBFS on armel: gsf-scan, ** ERROR **: Compilation trouble with endianess.
On 2008-10-24 10:48 +0300, Riku Voipio wrote:
> On Thu, Oct 23, 2008 at 10:29:54AM +0300, Riku Voipio wrote:
> > The error is coming from gsf-init. Reassigning accordingly.
>
> Thanks for fixing this promptly.
>
> > gsf thinks only vfp enabled arm uses natural endian doubles. However,
> > eabi does that as well. As anyone using vfp is also using eabi,
> > the correct change is to switch the define.
> > -#if defined(__arm__) && !defined(__vfp__) && (G_BYTE_ORDER == G_LITTLE_ENDIAN)
> > +#if defined(__arm__) && !defined(__ARM_EABI__) && (G_BYTE_ORDER == G_LITTLE_ENDIAN)
This is my/phil blundell's fault.
libgsf was fixed a long time ago - before eabi stuff had any sort of
plan in Debian. Using __vfp__ seemed like the best test at the time,
as recommended to me by pb. I'm not sure when you end up with
__ARM_EABI__ defined but __vfp__ not defined in practice, but I agree
the change is now correct.
> Is there some way to test libgsf double loading?
Make an Excel spreadsheet contining the numbers 1 to 4 on x86. Load it on
arm and armel. If the numbers are still 1-4 then it is working.
See original bugreps:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=250249
http://markmail.org/message/4f5jnyc4qynshe6l
Wookey
--
Principal hats: Balloonz - Toby Churchill - Aleph One - Debian
http://wookware.org/
Reply to: