[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Kerberos4KTH patch



Greetings,

I noticed the kerberos4kth packages aren't in non-us for PPC or ARM.
I've attached a patch which makes it build and work (basically the same
as my old one), but the maintainer (Greg Stark) doesn't like it.  His
objections:

   * The int arguments in va_arg calls should break shorts, and also
     longs on 64-bit platforms.  And yet, it builds with the patch,
     doesn't without it.  Tom Rini, your 12/15/99 debian-powerpc post
     was the basis of that part of the patch, do you know what's going
     on?  Is va_args somehow broken for PPC and/or ARM.
   * Greg doesn't think db1/ndbm.h is the right thing to do.  Seems that
     with all of the right -dev build dependencies, he can get it to
     build on i386 without this, either ndbm.h or an acceptible
     substitute is found just fine.  (Wish there was a build-depends
     line in the .dsc...)  Any ideas?

Until then, the patch...

-Adam P.

--- lib/roken/snprintf.c~	Sun Jan 30 14:17:09 2000
+++ lib/roken/snprintf.c	Sun Jan 30 14:25:39 2000
@@ -263,11 +263,11 @@
 
 #define PARSE_INT_FORMAT(res, arg, unsig) \
 if (long_flag) \
-     res = (unsig long)va_arg(arg, unsig long); \
+     res = (unsig long)va_arg(arg, int); \
 else if (short_flag) \
-     res = (unsig short)va_arg(arg, unsig short); \
+     res = (unsig short)va_arg(arg, int); \
 else \
-     res = (unsig int)va_arg(arg, unsig int)
+     res = (unsig int)va_arg(arg, int)
 
 /*
  * zyxprintf - return 0 or -1
--- configure.in~	Sun Jan 30 15:59:21 2000
+++ configure.in	Sun Jan 30 16:04:48 2000
@@ -352,6 +352,7 @@
 	curses.h				\
 	db.h					\
 	dbm.h					\
+	db1/ndbm.h				\
 	dirent.h				\
 	err.h					\
 	errno.h					\
--- aclocal.m4~	Thu Dec 16 11:03:04 1999
+++ aclocal.m4	Sun Jan 30 16:08:58 2000
@@ -825,6 +825,8 @@
 #include <fcntl.h>
 #if defined(HAVE_NDBM_H)
 #include <ndbm.h>
+#elif defined(HAVE_DB1_NDBM_H)
+#include <db1/ndbm.h>
 #elif defined(HAVE_DBM_H)
 #include <dbm.h>
 #elif defined(HAVE_RPCSVC_DBM_H)
--- cf/krb-find-db.m4~	Fri May  7 22:24:04 1999
+++ cf/krb-find-db.m4	Sun Jan 30 16:02:16 2000
@@ -28,6 +28,8 @@
 #include <fcntl.h>
 #if defined(HAVE_NDBM_H)
 #include <ndbm.h>
+#elif defined(HAVE_DB1_NDBM_H)
+#include <db1/ndbm.h>
 #elif defined(HAVE_DBM_H)
 #include <dbm.h>
 #elif defined(HAVE_RPCSVC_DBM_H)
--- include/config.h.in~	Sun Jan 30 15:06:26 2000
+++ include/config.h.in	Sun Jan 30 16:06:49 2000
@@ -536,6 +536,9 @@
 /* Define if you have the <dbm.h> header file.  */
 #undef HAVE_DBM_H
 
+/* Define if you have the <db1/ndbm.h> header file.  */
+#undef HAVE_DB1_NDBM_H
+
 /* Define if you have the <dirent.h> header file.  */
 #undef HAVE_DIRENT_H
 
--- lib/roken/xdbm.h~	Thu Dec  2 11:58:54 1999
+++ lib/roken/xdbm.h	Sun Jan 30 16:13:54 2000
@@ -40,6 +40,8 @@
 
 #ifdef HAVE_NDBM_H
 #include <ndbm.h>
+#elif defined(HAVE_DB1_NDBM_H)
+#include <db1/ndbm.h>
 #elif defined(HAVE_DBM_H)
 #include <dbm.h>
 #elif defined(HAVE_RPCSVC_DBM_H)

Reply to: