Bug#985012: apache2: Race condition in DEP8 test case t/apache/expr_string.t
Source: apache2
Version: 2.4.43-1
Severity: normal
Dear Maintainer,
One of the test cases has been seen to fail intermittently in Ubuntu,
so we added a small sleep to it which seems to have solved the problem.
I didn't notice that Debian hits this, but upstream did in the past, and
used the same solution to fix it.
https://bugs.launchpad.net/ubuntu/+source/apache2/+bug/1890302
Patch as applied to Ubuntu is attached.
Thanks,
Bryce
-- System Information:
Debian Release: bullseye/sid
APT prefers focal-updates
APT policy: (500, 'focal-updates'), (500, 'focal-security'), (500, 'focal'), (100, 'focal-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.4.0-65-generic (SMP w/12 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US:en (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages apache2-bin depends on:
ii libapr1 1.6.5-1ubuntu1
ii libaprutil1 1.6.1-4ubuntu2
ii libaprutil1-dbd-sqlite3 1.6.1-4ubuntu2
ii libaprutil1-ldap 1.6.1-4ubuntu2
ii libbrotli1 1.0.7-6ubuntu0.1
ii libc6 2.31-0ubuntu9.2
ii libcrypt1 1:4.4.10-10ubuntu4
ii libcurl4 7.68.0-1ubuntu2.4
ii libjansson4 2.12-1build1
ii libldap-2.4-2 2.4.49+dfsg-2ubuntu1.7
ii liblua5.2-0 5.2.4-1.1build3
ii libnghttp2-14 1.40.0-1build1
ii libpcre3 2:8.39-12build1
ii libssl1.1 1.1.1f-1ubuntu2.2
ii libxml2 2.9.10+dfsg-5
ii perl 5.30.0-9ubuntu0.2
ii zlib1g 1:1.2.11.dfsg-2ubuntu1.2
Versions of packages apache2-bin suggests:
pn apache2-doc <none>
pn apache2-suexec-pristine | apache2-suexec-c <none>
ii chromium-browser [www-browser] 1:85.0.4183.83-0ubuntu0.20.04.2
ii firefox [www-browser] 84.0.2+build1-0ubuntu0.20.04.1
ii google-chrome-stable [www-browser] 88.0.4324.96-1
ii links2 [www-browser] 2.20.2-1
ii lynx [www-browser] 2.9.0dev.5-1
Versions of packages apache2 is related to:
ii apache2 2.4.41-4ubuntu3.1
ii apache2-bin 2.4.41-4ubuntu3.1
>From 6ae8c18ed06dc19123c61616da55e6bb93b396bc Mon Sep 17 00:00:00 2001
From: Andreas Hasenack <andreas@canonical.com>
Date: Mon, 24 Aug 2020 18:18:55 -0300
Subject: [PATCH] - d/p/t/apache/expr_string.t: Avoid test suite failure
due to timing issue reading error log too quickly after request, by
adding a sleep. (LP #1890302)
---
debian/perl-framework/t/apache/expr_string.t | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/debian/perl-framework/t/apache/expr_string.t b/debian/perl-framework/t/apache/expr_string.t
index a9115eeec..66b09030d 100644
--- a/debian/perl-framework/t/apache/expr_string.t
+++ b/debian/perl-framework/t/apache/expr_string.t
@@ -7,6 +7,8 @@ use Apache::TestUtil qw(t_write_file t_start_error_log_watch t_finish_error_log_
use File::Spec;
+use Time::HiRes qw(usleep);
+
# test ap_expr
Apache::TestRequest::user_agent(keep_alive => 1);
@@ -62,6 +64,8 @@ foreach my $t (@test_cases) {
'SomeHeader' => 'SomeValue',
'User-Agent' => 'SomeAgent',
'Referer' => 'SomeReferer');
+ ### Sleep here, attempt to avoid intermittent failures. (LP: #1890302)
+ usleep(250000);
my @loglines = t_finish_error_log_watch();
my @evalerrors = grep {/(?:internal evaluation error|flex scanner jammed)/i
--
2.30.0
Reply to: