Bug#251048: apache-common: listconffiles doesn't cope well with extra whitespace

[Pierfrancesco Caci <ik5pvx@home.tippete.net>]

:-> "Fabio" == Fabio Massimo Di Nitto <fabbione@fabbione.net> writes:


    > On Wed, 26 May 2004, Colm Buckley wrote:

    >> Package: apache-common
    >> Version: 1.3.31-1
    >> Severity: normal
    >> 
    >> listconffiles doesn't cope well with extra whitespace in the lines
    >> containing ServerRoot or Include directives in httpd.conf.  The attached
    >> patch makes it a lot happier.
    >> 


    >> # By specifying fields in split we allow for filename containing spaces.
    >> if (/^\s*serverroot/i) {
    >> -      s/^\s*(.*)/$1/;
    >> -      (undef,$serverroot) = split (/\s/,$_,2);
    >> -

    > Can you kindly include the error you get and add comments to what you
    > changed and why? I am not a perl expert and i am kinda unhappy to apply
    > patches without someone reviewing them twice.

I can't remember what whas the reason for hooking the regex to the
beginning of the line.. I think it was to cope with users putting
comments containing the word we're looking for, and we want to skip
those.

I'll try a modified version of the original split line when I come
back home.

Pf



-- 

-------------------------------------------------------------------------------
 Pierfrancesco Caci | ik5pvx | mailto:p.caci@tin.it  -  http://gusp.dyndns.org
  Firenze - Italia  | Office for the Complication of Otherwise Simple Affairs 
     Linux penny 2.6.6-rc2-mm1 #1 Sat Apr 24 17:20:00 CEST 2004 i686 GNU/Linux