Hi Christian,
this script should go into pkg-rocm-tools, and other packages should build-depend on it and copy it to the relevant destination. Otherwise we'll end up with dozens of often-diverging copies of some runner, as we saw for upstream-binaries.This does not. We should not be copying files; it's a needless maintenance chore and tedious to keep in sync. It would be simpler to keep a master copy somewhere and either use that to run the tests, or symlink to it if necessary. runner: /usr/share/pkg-rocm-tools/bin/run-tests invocation: /usr/share/pkg-rocm-tools/bin/run-tests <package> or symlink /usr/libexec/rocm/<package>/run-tests to that, and have <package> inferred from the pwd. Or both.
I think the main difficulty is that /something/ is going to have to handle categorizing and invoking the tests for each library and that 'something' is going to therefore end up looking slightly different for almost every library. If we isolate the 'something' so that we can reuse a single shared script, we're going to end up having to define an interface between the shared and the unique parts.
I would be tempted to just keep the run-tests scripts very simple
and live with the duplication between scripts from different
packages (as long as they present a consistent interface). If we
discover a great way to split the shared and unique parts, we can
always refactor at that time.
Sincerely,
Cory Bloor