Re: Running autopkgtests with AMD GPUs with rocm-test-launcher
Hi Cory,
On 2025-06-12 02:57, Cordell Bloor wrote:
> On 2025-04-24 02:09, Christian Kastner wrote:
>> it might even be a good idea to ship such a wrapper for *all*
>> packages, even the single-test ones, to provide a unified, well-known
>> entry point for running tests, so that tests for any -tests <binpkg>
>> can always be launched with
>>
>> $ /usr/libexec/rocm/<binpkg>/runtests
>>
> Let's do this.
>
> I did a bit of brainstorming on alternative verbs, but I couldn't come
> up with anything better than run-tests. The best alternative I could
> come up with was "verify", but the path to the script refers to the test
> package, not the library it is verifying. My only suggestion for
> improvement would be to put a dash in between "run" and "test" just for
> consistency with the package name.
Agreed.
> I would also suggest an optional "--filter" argument supported by all
> versions of the script. The filter categories would be "smoke", "basic",
> "extended", or "special".
> The filter categories are chosen because there are corresponding options
> upstream for all libraries that we can draw from
Makes sense. If these categories are not defined by us but by upstream,
I'd also give -upstream-filter some thought, but I don't mind either
way.
The script must also either collect some GTest options and pass them on,
or pass all other arguments to the tests entirely (so $@ minus the
--filter option). For example, the previously mentioned rocrand [1] and
hipsolver [2] both use this to trigger an XML export of the test results
as autopkgtest artifacts.
In the same vein, the options should probably also be supported as
envvars, which is useful to CI environments which test Debian (or
Ubuntu) in containers. It allows for single-container re-use.
Finally, this script should go into pkg-rocm-tools, and other packages
should build-depend on it and copy it to the relevant destination.
Otherwise we'll end up with dozens of often-diverging copies of some
runner, as we saw for upstream-binaries.
Best,
Christian
[1]:https://sources.debian.org/src/rocrand/5.7.1-6/debian/tests/run-testdir/
[2] https://sources.debian.org/src/hipsolver/5.5.1-8/debian/tests/control/
Reply to: