Hi Christian,
I performed a more thorough check and not it's not just kde -- there are
also pkg-{js,perl,haskell,php}-tools.
Thus, I'll name the binary pkg-rocm-tools.
+1. That makes sense.
I've finished the first version of the test helper [1]. I've embedded this version in new releases of hipsolver (1-autopkgtest, 1-executable) and rocrand (2-autopkgtests, N-executables), and converted their autopkgtests to make use of it. I think this turned out nicely: d/tests/control of both packages are minimal [2, 3], hipsolver needs no extra file, and rocrand just needs a tiny wrapper to run N-executables [4].
This looks great, but if you're open to a final bit of bikeshedding, I would suggest changing the rocm-testhelper name. The "helper" adjective is a generic description and does not provide any indication of what the utility does. Whenever possible, I would recommend replacing "helper" with something more specific.
My suggestion would be "rocm-test-launcher" and updating the environment variables to --env=ROCM_TEST_LAUNCHER_WITH_DMESG=1 --env=ROCM_TEST_LAUNCHER_WITH_DRI=/dri. I think this better describes how the executable is used. It also matches the terminology found in CMake [8].
I'm fine with whatever you choose. I just think it's worth
spending a few minutes considering this topic.
Sincerely,
Cory Bloor
[1]: which I named rocm-testhelper since technically, it can also be
used for non-autopkgtest execution.
[2]: https://salsa.debian.org/rocm-team/hipsolver/-/blob/master/debian/tests/control
[3]: https://salsa.debian.org/rocm-team/rocrand/-/blob/master/debian/tests/control
[4]: https://salsa.debian.org/rocm-team/rocrand/-/blob/master/debian/tests/run-testdir
[5]: Though this requires tests to depend on rocminfo, or rocminfo to
be installed in the base image.
[6]: https://ci.rocm.debian.net/data/autopkgtest/unstable/amd64+gfx1030/h/hipsolver/37173/artifacts.tar.gz
[7]: https://ci.rocm.debian.net/data/autopkgtest/unstable/amd64+gfx1030/h/hipsolver/37226/artifacts.tar.gz
[8]: https://cmake.org/cmake/help/latest/prop_tgt/TEST_LAUNCHER.html