[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: rocm-autopkgtest-helper



Hi Cory,

On 2024-10-20 04:53, Cordell Bloor wrote:
> This looks great, but if you're open to a final bit of bikeshedding,

Not just open to, but strongly requesting it :) I do not enjoy naming
things.

> I would suggest changing the rocm-testhelper name. The "helper" adjective
> is a generic description and does not provide any indication of what the
> utility does. Whenever possible, I would recommend replacing "helper"
> with something more specific.
> 
> My suggestion would be "rocm-test-launcher" and updating the environment
> variables to  --env=ROCM_TEST_LAUNCHER_WITH_DMESG=1
> --env=ROCM_TEST_LAUNCHER_WITH_DRI=/dri. I think this better describes
> how the executable is used. It also matches the terminology found in
> CMake [8].

That sounds good. Done.

I've cut new release to apt.r.d.n. to have a final check before
uploading to the experimental.

I'll also cut a new hipsolver release with the new script, just to make
sure.

Best,
Christian

> [8]: https://cmake.org/cmake/help/latest/prop_tgt/TEST_LAUNCHER.html


Reply to: