[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Updating rocr-runtime to 5.7.1




On 2023-11-28 23:22, Cordell Bloor wrote:

On 2023-11-25 22:55, Cordell Bloor wrote:
I was updating rocr-runtime from 5.2.3 to 5.7.1, but it seems that there were some precompiled shaders introduced in 5.3.0. I'm trying to find more information about these binary blobs [1].

The sources can be found in amd_blit_kernel.cpp [2]. I'm not entirely sure how to assemble SP3 shaders to reproduce those binary blobs, but I suppose it must be possible given that the sources long predate the blobs.

It was pointed out to me that these blobs were merely moved to a different header in ROCm 5.7. They date back to ROCm 1.2 [3] and were included in rocr when it was originally packaged for Debian [4]. As mentioned, the sources are available, although I'm still a bit unclear on how the provided sources can be assembled into the precompiled binaries.

If this is a problem, it affects all versions of rocr-runtime that have ever been packaged for Debian. As such, I will proceed with the update to ROCm 5.7 as it does not introduce any new issues.

Sincerely,
Cory Bloor

[1]: https://github.com/RadeonOpenCompute/ROCR-Runtime/blob/rocm-5.7.1/src/core/inc/amd_blit_shaders.h
[2]: https://github.com/RadeonOpenCompute/ROCR-Runtime/blob/rocm-5.7.1/src/core/runtime/amd_blit_kernel.cpp#L57

[3]: https://github.com/RadeonOpenCompute/ROCR-Runtime/commit/a6047746e4e7a8cd939c1f6cbfc7e865c9ac1a95 [4]: https://salsa.debian.org/rocm-team/rocr-runtime/-/blob/debian/3.3.0-1_exp1/src/core/inc/amd_gpu_shaders.h#L48



Reply to: