[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1036887: unblock: rocrand/5.3.3-4



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: rocrand@packages.debian.org
Control: affects -1 + src:rocrand

Please unblock package rocrand

Note that the changes to bookworm are minimal and the only effective
change is fixing the missing dependencies in d/control, as stated under
Reason below.

However: d/changelog is noisy because we had changes in unstable that I
reverted for this -4 release, so that the fix can go through unstable.
(We had changes in unstable, rather than experimental, due to an
extremely poor judgment call on my end. Sorry.)

[ Reason ]
rocrand is missing explicit dependencies on libamdhip64-dev.

[ Impact ]
Users installing librocrand-dev or libhiprand-dev will not be able to
use them without also installing libamdhip64-dev, and it is not
immediately made clear what the actual cause of the error is.

[ Tests ]
This package does not yet have autopkgtests but in this particular case,
the change is minimal and only affects d/control.

[ Risks ]
None, compared to the previous release in bookworm -1.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]
None.

unblock rocrand/5.3.3-4
diff -Nru rocrand-5.3.3/debian/changelog rocrand-5.3.3/debian/changelog
--- rocrand-5.3.3/debian/changelog	2023-02-07 08:06:45.000000000 +0100
+++ rocrand-5.3.3/debian/changelog	2023-05-28 18:25:03.000000000 +0200
@@ -1,3 +1,33 @@
+rocrand (5.3.3-4) unstable; urgency=medium
+
+  * Temporarily revert fixes unfit for bookworm.
+    Specifically, revert all changes from after 5.3.3-1.
+
+  * Add missing dependency on libamdhip64-dev (Closes: #1035784, #1035787)
+
+ -- Christian Kastner <ckk@debian.org>  Sun, 28 May 2023 18:25:03 +0200
+
+rocrand (5.3.3-3) unstable; urgency=medium
+
+  * Upload to unstable.
+
+ -- Christian Kastner <ckk@debian.org>  Sun, 16 Apr 2023 22:45:08 +0200
+
+rocrand (5.3.3-3~exp1) experimental; urgency=medium
+
+  * Add myself to Uploaders
+  * Fix Maintainer name
+  * Add packages librocrand1-test, libhiprand1-test providing autopkgtests
+
+ -- Christian Kastner <ckk@debian.org>  Thu, 13 Apr 2023 23:41:30 +0200
+
+rocrand (5.3.3-2) unstable; urgency=medium
+
+  * d/rules: enable hardening flags
+  * d/rules: enable gfx1010 and gfx1011
+
+ -- Cordell Bloor <cgmb@slerp.xyz>  Mon, 06 Mar 2023 00:41:11 -0700
+
 rocrand (5.3.3-1) unstable; urgency=medium
 
   * d/{watch,gbp.conf}: recombine with hiprand as MUT
diff -Nru rocrand-5.3.3/debian/control rocrand-5.3.3/debian/control
--- rocrand-5.3.3/debian/control	2023-02-07 07:22:45.000000000 +0100
+++ rocrand-5.3.3/debian/control	2023-05-28 18:25:03.000000000 +0200
@@ -14,6 +14,7 @@
                hipcc,
                git,
                libamd-comgr-dev,
+               libamdhip64-dev,
                libhsa-runtime-dev,
                patchelf,
                rocminfo,
@@ -38,7 +39,10 @@
 Package: librocrand-dev
 Section: libdevel
 Architecture: any
-Depends: librocrand1 (= ${binary:Version}),${misc:Depends}, ${shlibs:Depends},
+Depends: librocrand1 (= ${binary:Version}),
+         libamdhip64-dev,
+         ${misc:Depends},
+         ${shlibs:Depends},
 Description: generate pseudo- and quasi-random numbers - headers
  The rocRAND project provides functions that generate pseudo-random and
  quasi-random numbers.
@@ -64,7 +68,10 @@
 Package: libhiprand-dev
 Section: libdevel
 Architecture: any
-Depends: libhiprand1 (= ${binary:Version}),${misc:Depends}, ${shlibs:Depends},
+Depends: libhiprand1 (= ${binary:Version}),
+         libamdhip64-dev,
+         ${misc:Depends},
+         ${shlibs:Depends},
 Description: wrapper library to port from cuRAND applications to HIP - headers
  The rocRAND project includes a wrapper library called hipRAND which allows
  user to easily port CUDA applications that use cuRAND library to the HIP

Reply to: