[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

ROCm 4.5.2 Compiler support code object manager - Debian package wonder

 Hello Jeremy,

I am busy with the Debian ROCm team [1] packaging ROCm.
I have a wonder as I saw you active in comgr development:
We are trying to package ROCm 4.5.2 with the official LLVM 13
toolchain instead of AMD LLVM forks [2].

Compiling comgr with upstream llvm-13 runs into issues, I patched them
from the amd-stg-open branch, current commit HEAD~1 [SHA1|3].
I am especially worried about the 0002-MCStreamer-InitSections patch.
Is such a patch acceptable [4]? Will it break subtly something
important? Does it do anything except allowing me to compile comgr?

So far as you can see from [2], the whole stack has been passing most
tests and benchmarks (but not all) with this patch and llvm-13.

Best regards, Maxime

[1] https://salsa.debian.org/rocm-team
[2] https://lists.debian.org/debian-ai/2022/01/msg00000.html
[3] 675501d47b582807183c4bc28d848e76118d3aa9
[4] https://salsa.debian.org/rocm-team/rocm-compilersupport/-/blob/master/debian/patches/0002-MCStreamer-InitSections.patch
From: Maxime Chambonnet <maxzor@maxzor.eu>
Date: Sun, 19 Dec 2021 06:35:13 +0100
Subject: MCStreamer::InitSections

 lib/comgr/src/comgr-compiler.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/comgr/src/comgr-compiler.cpp b/lib/comgr/src/comgr-compiler.cpp
index 9580fd7..12162d9 100644
--- a/lib/comgr/src/comgr-compiler.cpp
+++ b/lib/comgr/src/comgr-compiler.cpp
@@ -481,7 +481,7 @@ static bool executeAssemblerImpl(AssemblerInvocation &Opts,
         MAB->createObjectWriter(*Out), std::unique_ptr<MCCodeEmitter>(CE), *STI,
         Opts.RelaxAll, Opts.IncrementalLinkerCompatible,
         /*DWARFMustBeAtTheEnd*/ true));
-    Str.get()->InitSections(Opts.NoExecStack, *STI);
+    Str.get()->InitSections(true);
   bool Failed = false;

Reply to: