[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#548550: marked as done (brltty: Incorrect dependencies in init.d LSB header)

Your message dated Sun, 27 Sep 2009 12:47:28 +0000
with message-id <E1MrtA0-00021w-U2@ries.debian.org>
and subject line Bug#548550: fixed in brltty 4.0-9
has caused the Debian Bug report #548550,
regarding brltty: Incorrect dependencies in init.d LSB header
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

548550: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=548550
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package:  brltty
Version:  3.8-1
Severity: important
Tags:     patch
User:     initscripts-ng-devel@lists.alioth.debian.org
Usertags: incorrect-dependency
User:     debian-qa@lists.debian.org
Usertags: piuparts

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d scripts of this package.  The script have a hard
dependency on udev, yet the package do not depend on udev.  I assume
the udev init.d script dependency should be a soft dependency.  Also,
the header claim the script should stop in runlevels 0 and 6, yet the
arguments to update-rc.d state that it should only start and not stop.

I discovered these things from piuparts, which failed to install the
package.  See
<URL:http://piuparts.debian.org/sid/fail/brltty_4.0-8.log>.  Here are
the relevant parts:

  update-rc.d: warning: brltty stop runlevel arguments (none) do not
    match LSB Default-Stop values (0 6)
  insserv: Service udev has to be enabled to start service brltty
  insserv: exiting now!

I'm setting severity important and not serous, as udev is installed on
most systems and the error only trigger on systems without udev.

This patch should solve it, by making udev an optional dependency and
changing the stop symlinks.  The postinst code is there to remove the
stop symlinks from existing installations which installed brltty when
dependency based boot sequencing was in effect, to allow the debhelper
added code to reinsert it at the correct location.

diff -ur ../brltty-4.0/debian/brltty.init ../brltty-4.0-pere/debian/brltty.init
--- ../brltty-4.0/debian/brltty.init    2009-09-27 08:10:32.000000000 +0200
+++ ../brltty-4.0-pere/debian/brltty.init       2009-09-27 08:17:11.000000000 +0200
@@ -1,12 +1,12 @@
 #! /bin/sh
 # Provides:          brltty
-# Required-Start:    mountkernfs udev
-# Required-Stop:
-# Should-Start:
+# Required-Start:    mountkernfs
+# Required-Stop:
+# Should-Start:      udev
 # Should-Stop:
 # Default-Start:     S
-# Default-Stop:      0 6
+# Default-Stop:
 # Short-Description: Braille terminal driver
 # Description: Used to provide access to refreshable braille terminals.
diff -ur ../brltty-4.0/debian/brltty.postinst ../brltty-4.0-pere/debian/brltty.postinst
--- ../brltty-4.0/debian/brltty.postinst        2009-09-27 08:10:32.000000000 +0200
+++ ../brltty-4.0-pere/debian/brltty.postinst   2009-09-27 08:27:54.000000000 +0200
@@ -9,5 +9,13 @@

 #update-rc.d brltty start 10 23 > /dev/null

+# Recover from incorrect init.d script headers in version 4.0-8 and earlier
+if [ "$1" = "configure" ] && dpkg --compare-versions "$2" le "4.0-8" \
+   && [ -f /etc/rcS.d/S[0-9][0-9]brltty ] \
+   && [ -f /etc/rc0.d/K[0-9][0-9]brltty ] \
+   && [ -f /etc/rc6.d/K[0-9][0-9]brltty ] ; then
+    update-rc.d -f brltty remove

Happy hacking,
Petter Reinholdtsen

--- End Message ---
--- Begin Message ---
Source: brltty
Source-Version: 4.0-9

We believe that the bug you reported is fixed in the latest version of
brltty, which is due to be installed in the Debian FTP archive:

  to pool/main/b/brltty/brltty-flite_4.0-9_amd64.deb
  to pool/main/b/brltty/brltty-speechd_4.0-9_amd64.deb
  to pool/main/b/brltty/brltty-udeb_4.0-9_amd64.udeb
  to pool/main/b/brltty/brltty-x11_4.0-9_amd64.deb
  to pool/main/b/brltty/brltty_4.0-9.diff.gz
  to pool/main/b/brltty/brltty_4.0-9.dsc
  to pool/main/b/brltty/brltty_4.0-9_amd64.deb
  to pool/main/b/brltty/cl-brlapi_4.0-9_all.deb
  to pool/main/b/brltty/libbrlapi-dev_4.0-9_amd64.deb
  to pool/main/b/brltty/libbrlapi-java_4.0-9_all.deb
  to pool/main/b/brltty/libbrlapi-jni_4.0-9_amd64.deb
  to pool/main/b/brltty/libbrlapi0.5_4.0-9_amd64.deb
  to pool/main/b/brltty/python-brlapi_4.0-9_amd64.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 548550@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Mario Lang <mlang@debian.org> (supplier of updated brltty package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Sun, 27 Sep 2009 14:22:55 +0200
Source: brltty
Binary: brltty libbrlapi0.5 libbrlapi-dev libbrlapi-jni libbrlapi-java brltty-flite brltty-speechd brltty-udeb brltty-x11 cl-brlapi python-brlapi
Architecture: source amd64 all
Version: 4.0-9
Distribution: unstable
Urgency: low
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Mario Lang <mlang@debian.org>
 brltty     - Access software for a blind person using a braille display
 brltty-flite - Access software for a blind person using a braille display
 brltty-speechd - Access software for a blind person using a braille display
 brltty-udeb - Access software for a blind person using a braille display (udeb)
 brltty-x11 - Access software for a blind person using a braille display
 cl-brlapi  - Common Lisp bindings for BrlAPI
 libbrlapi-dev - Library for communication with BRLTTY - static libs and headers
 libbrlapi-java - Java bindings for BrlAPI
 libbrlapi-jni - Java bindings for BrlAPI (native library)
 libbrlapi0.5 - braille display access via BRLTTY - shared library
 python-brlapi - Python bindings for BrlAPI
Closes: 548550
 brltty (4.0-9) unstable; urgency=low
   * Incorrect dependencies in init.d LSB header (Closes: Bug#548550)
   * Fix weak-library-dev-dependency of libbrlapi-dev on libbrlapi0.5
 ad683c0b3866e22f1794346a8dcf0efe4cde9b1e 1693 brltty_4.0-9.dsc
 ef63226a3b62331698081e46f2a3ad2a6d84b6c7 27006 brltty_4.0-9.diff.gz
 4468de1414a5fa6cc79e4af8885dcf7f1136ca7f 1503406 brltty_4.0-9_amd64.deb
 60bfda557dff46a50657544bc87d30c0b8a75e9c 68798 libbrlapi0.5_4.0-9_amd64.deb
 db3ee9f96bb2e80b83cfbed013e63e55bda26ab9 172764 libbrlapi-dev_4.0-9_amd64.deb
 39b1843c57ce5f1d46e658e1537103d8b71aabee 60408 libbrlapi-jni_4.0-9_amd64.deb
 ccb8072b4854b6f8f95cd88673bf660fff6e5b46 54166 brltty-flite_4.0-9_amd64.deb
 e2eeb12b278ec02ccd2cf7dcc072c0d73e2d5521 54968 brltty-speechd_4.0-9_amd64.deb
 094faee165bde6dea27f25513425017900975337 106820 brltty-x11_4.0-9_amd64.deb
 2a08e9fd93cc6e85b13191666aeb14944ee63b33 92668 python-brlapi_4.0-9_amd64.deb
 55e42afdbd6966905f7fde2452a889747503702a 59958 libbrlapi-java_4.0-9_all.deb
 a933c4f358b0f524cfdc475a080b0d6cebbd56f5 53770 cl-brlapi_4.0-9_all.deb
 0be2cb8d3a4416784bf3c36639ef70bd0623ad5a 236542 brltty-udeb_4.0-9_amd64.udeb
 566649d369468d0d1a430706901735996c7bbdc971edd4a63d5160e305664ace 1693 brltty_4.0-9.dsc
 5582bfa2cea3130a7ec4a9938c6c8cb10f3948ca6b743a795b8ccd536dd73c9b 27006 brltty_4.0-9.diff.gz
 2f4c32b7f4542be4969a30428e515e7374275e70e7b9b4393f609eda71421785 1503406 brltty_4.0-9_amd64.deb
 7c1483d5ce9aa577446800ce84d20cd0c7d79e77115e88423cbdebfc94e6e7a0 68798 libbrlapi0.5_4.0-9_amd64.deb
 234dddada42624ecfeed558cbff742d323140d7226bd22a3ec645fafcd936f65 172764 libbrlapi-dev_4.0-9_amd64.deb
 1c65ceea05333edf2f58e66cc1940f530dc643353ce77ca11f376ead914088e9 60408 libbrlapi-jni_4.0-9_amd64.deb
 4c3a11ad0ac9a169635d76b878f95f39556a73c4fe89613587edbd2a262653b2 54166 brltty-flite_4.0-9_amd64.deb
 e098e3fef463690c1d06936e0992f8a421655d675cb78cdd6bbc3e96fe41b75c 54968 brltty-speechd_4.0-9_amd64.deb
 5ad19e2b8491894253c49d3e7cd9308a75db99aff4a6e92f2aa2ec37757f9f94 106820 brltty-x11_4.0-9_amd64.deb
 188ee350c6a89932e26522358725d004c1df02e324570c4921cedc64628f2776 92668 python-brlapi_4.0-9_amd64.deb
 4dac78a64277af1a8715158002e03561fdd4916f3c030d7326e81070fa160744 59958 libbrlapi-java_4.0-9_all.deb
 08f8c1a1099134b3d427e1b90fb6ad4c24c2cfc9647932549beee733cf379efa 53770 cl-brlapi_4.0-9_all.deb
 8cf4a9031bb49ab361963c440ded93f0af9e309c3638c47e642484a17638f1fc 236542 brltty-udeb_4.0-9_amd64.udeb
 d98420567b029b954ec94c6bec3a3e82 1693 admin extra brltty_4.0-9.dsc
 7069801c0eaf634450c497bafa800215 27006 admin extra brltty_4.0-9.diff.gz
 6667ff007d2e80f619f3c779db4d0605 1503406 admin extra brltty_4.0-9_amd64.deb
 824216c0b41b6d1e426253e5649d3cca 68798 libs extra libbrlapi0.5_4.0-9_amd64.deb
 1cd76426801e309acd6842801d0cb988 172764 libdevel extra libbrlapi-dev_4.0-9_amd64.deb
 589c9ce4d587fdbbda04da7b27dcd7d4 60408 libs extra libbrlapi-jni_4.0-9_amd64.deb
 d3d25c2ec2d8abc63441570a63358912 54166 admin extra brltty-flite_4.0-9_amd64.deb
 0a774fe29d5cc35721cc3d9fc5af97fb 54968 admin extra brltty-speechd_4.0-9_amd64.deb
 c3d3f7ef559308e56a42417fb5840036 106820 admin extra brltty-x11_4.0-9_amd64.deb
 9cb7eb798269c9163eb7a1fa0cb74dff 92668 python extra python-brlapi_4.0-9_amd64.deb
 2a3ec9b7e9d000fb681f944d5132c9bd 59958 java extra libbrlapi-java_4.0-9_all.deb
 767f8bb2f67ea2beeb8ad7f2ac21bda0 53770 lisp extra cl-brlapi_4.0-9_all.deb
 26973cd4bf2426e2b0ce1896265b4d2b 236542 debian-installer extra brltty-udeb_4.0-9_amd64.udeb
Package-Type: udeb

Version: GnuPG v1.4.10 (GNU/Linux)


--- End Message ---

Reply to: