Re: perl_5.32.0~rc1-1 FTBFS on m68k (experimental)

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Adrian,

On Fri, Jun 19, 2020 at 12:08 PM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
> This works, both with PERL_DEBUG_READONLY_OPS and without:
>
> diff --git a/op.h b/op.h
> index fc21f03cda..fc7e73fef4 100644
> --- a/op.h
> +++ b/op.h
> @@ -713,7 +713,9 @@ struct opslab {
>                                             units) */
>  # ifdef PERL_DEBUG_READONLY_OPS
>      bool       opslab_readonly;
> +    U8         opslab_padding1[3];
>  # endif
> +    U16        opslab_padding2;
>      OPSLOT     opslab_slots;           /* slots begin here */
>  };

So now you have 5 bytes of padding if PERL_DEBUG_READONLY_OPS,
while I guess 1 would be sufficient?

What about

    # ifdef PERL_DEBUG_READONLY_OPS
        bool       opslab_readonly;
        U8         opslab_padding;
    #else
        U16        opslab_padding;
    # endif

?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds