Re: perl_5.32.0~rc1-1 FTBFS on m68k (experimental)

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Adrian,

On Fri, Jun 19, 2020 at 10:52 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
> On 6/19/20 10:47 AM, John Paul Adrian Glaubitz wrote:
> > It might be set during stage1, but not stage2.
> >
> > I will have to look at it again.
>
> I just tried this change and it doesn't fix the problem:

That's actually expected ;-)

> --- a/op.h
> +++ b/op.h
> @@ -713,6 +713,8 @@ struct opslab {
>                                             units) */
>  # ifdef PERL_DEBUG_READONLY_OPS
>      bool       opslab_readonly;

implicit padding of 1 byte

> +    U16         _padding1;               /* additional padding to ensure opslab is 32-bit aligned */
> +    U8          _padding2;               /* when PERL_DEBUG_READONLY_OPS is set */

implicit padding of 1 byte

>  # endif
>      OPSLOT     opslab_slots;           /* slots begin here */
>  };

Either invert the order of the two paddings, or replace them by a single one:

    U8  _padding[3];

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds