On Mon, Oct 21, 2019 at 08:39:17PM +0200, John Paul Adrian Glaubitz wrote:
> ifneq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
> CONFIGURE_FLAGS += -DBUILD_TESTS=0 -DBUILD_EXAMPLES=1
> endif
>
> With the paragraph removed, "nocheck" still works as expected and building
> with "nocheck" no longer results in a broken soxr.pc.
This was added by Helmut to fix a FTCBFS. Are you sure removing the
-DBUILD_TESTS=0 doesn't break cross builds?
Also, the fact that a thing such as BUILD_EXAMPLE affects the content of
the .pc files sounds wrong on many levels, so I'd rather see it fixed
some other way.
I haven't tested, but in particular I noticed this oddity in the
top-level CMakeFile.txt:
103 if (${BUILD_EXAMPLES})
104 project (${PROJECT_NAME}) # Adds c++ compiler
105 endif ()
that looks very suspicious.
So, I wrote a different patch (that one day should be forwarded
upstream) and committed it.
BTW, Adrian: autopkgtest is reporting a new error, specifically a
segfault in amd64. That looks incredibly suspicious, could you please
look at it? I'd like to see a fix for that before doing a new upload.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature