Bug#908380: ipsvd: Please honour "nocheck" in DEB_BUILD_OPTIONS

[John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>]

Source: ipsvd
Version: 1.0.0-3.1
Severity: important
User: debian-68k@lists.debian.org
Usertags: m68k

Hello!

The debian/rules file for ipsvd currently builds the package
and runs its testsuite within the same rules target without
checking whether "nocheck" is set in DEB_BUILD_OPTIONS or
not:

build-stamp: patch-stamp
        -gcc -v
        test -e ipsvd || ln -s ipsvd-1.0.0 ipsvd
        test -r conf-cc'{orig}' || cp -f ipsvd/src/conf-cc conf-cc'{orig}'
        echo '$(CC) $(CFLAGS)' >ipsvd/src/conf-cc
        test -r conf-ld'{orig}' || cp -f ipsvd/src/conf-ld conf-ld'{orig}'
        echo '$(CC) $(LDFLAGS)' >ipsvd/src/conf-ld
        (cd ipsvd/ && package/compile && package/check)
        touch build-stamp

This means that it is not possible to build the package without
running the testsuite meaning it will be hard to cross-build the
package or it building in emulated build environments where
tests can produce unexpected results.

In order to address this issue, the call to "package/check"
should be moved to the "check:" target of debian/rules although
I'm not sure whether it's actually called like that. I haven't
worked with rules files that old which don't use modern debhelper
syntax for ages.

Thanks,
Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913