[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#717689: linux: please review and merge m68k patch



On Tue, 2013-07-23 at 22:11 +0000, Thorsten Glaser wrote:
[...]
> >> -CONFIG_EXT4_USE_FOR_EXT23=y
> >
> >You could still stick to this option.
> 
> The debian/config/config doesn’t use it and builds
> separate ext2/ext3/ext4 modules instead, so I did
> that too.

I think we may want to enable this at the top level later, but there is
no reason to override it now.

> >> +CONFIG_NFS_SWAP=y

Really?

> >> +CONFIG_NLS_MAC_ROMAN=m
> >> +CONFIG_NLS_MAC_CELTIC=m
> >> +CONFIG_NLS_MAC_CENTEURO=m
> >> +CONFIG_NLS_MAC_CROATIAN=m
> >> +CONFIG_NLS_MAC_CYRILLIC=m
> >> +CONFIG_NLS_MAC_GAELIC=m
> >> +CONFIG_NLS_MAC_GREEK=m
> >> +CONFIG_NLS_MAC_ICELAND=m
> >> +CONFIG_NLS_MAC_INUIT=m
> >> +CONFIG_NLS_MAC_ROMANIAN=m
> >> +CONFIG_NLS_MAC_TURKISH=m
> >
> >Why here?
> 
> Because debian/config/config didn’t contain them.
> But they could be moved there, yes – but I didn’t
> want to touch !m68k space.

Apple has gone through a few architectures since m68k. :-)

> >> +CONFIG_LOG_BUF_SHIFT=16
> >
> >Why override?
> 
> Saving some more space… I will retract this line
> if you say so.

I think this is reasonable since m68k machines may have very little RAM.

> >> +## choice: Preemption Model
> >> +CONFIG_PREEMPT_NONE=y
> >> +# CONFIG_PREEMPT_VOLUNTARY is not set
> >> +# CONFIG_PREEMPT is not set
> >> +## end choice
> >
> >Isn't this already set?
> 
> No, it’s set to CONFIG_PREEMPT_VOLUNTARY.
[...]

Now why do you want to change that?

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: