Re: fs-uae_2.2.3-1_amd64.changes REJECTED
Hello Paul,
thanks for reviewing fs-uae again!
It's a pity it got rejected again since we are desperately waiting
for fs-uae to be in the archives so we can finally get rid of both
"uae" and "e-uae" which have been abandoned both in Debian as well
upstream.
As for your complaints, I understand that we always want to have
100%-DFSG-compliant packages in Debian. However, I'm afraid,
that's not always possible.
For fs-uae, which is a fork of uae, this holds true because the
source has been modified by dozens of developers and has been
forked several times since uae was initially released. There
are so many contributions that it is sometimes not feasible to
get the proper source or figure out who holds the copyright.
I fully agree that this is not the optimal situation, but sometimes
we should find a compromise when the last percent to get the
100% compliance are nearly impossible to get.
Interestingly, the file "filesys_bootrom.cpp" is already part
both of "uae" and "e-uae" which are currently both in the
Debian archive. It's part of the uae sources and subject
to it's copyright.
Both filesys_bootrom.cpp and core.cw4.cpp (a firmware to
support the Catweasel controller by Individual Computers)
are native m68k code. There isn't much point in providing
the source code for these, I'd assume they have been
written in m68k assembler.
As for the "sinctable.cpp" file, I'm not sure exactly what it does,
but is it really necessary to have the Python script available?
I'll ask upstream.
In any case,
*sigh*
Adrian
On 11/01/2013 01:00 AM, Paul Richards Tagliamonte wrote:
>
> Howdy maintainer,
>
> I'm rejecting this package, since I don't believe the full source
> is being included.
>
> core.cw4.cpp appears to be sourceless (entirely)
>
> I can't see what's in filesys_bootrom.cpp (can you please examine the
> contents for file freeness and document that in the copyright if it
> needs to be) - can't this be built at build-time (or at least with a
> script?)
>
> sinctable.cpp says it's generated by contrib/sinc-integral.py, but this
> file isn't present in the source tarball (ergo incomplete source)
>
> Thanks!
> Paul
>
> ===
>
> Please feel free to respond to this email if you don't understand why
> your files were rejected, or if you upload new files which address our
> concerns.
>
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Reply to: