Re: [RFC] m68k: Update defconfigs for v3.9
On Sun, 26 May 2013, Finn Thain wrote:
>
> On Sun, 26 May 2013, Laurent Vivier wrote:
>
> > Le 26/05/2013 02:30, Finn Thain a ecrit :
> >
> > This works if I disable "EARLY_PRINTK". To do that I need to patch
> > Kconfig :
> >
> > --- a/arch/m68k/Kconfig.debug
> > +++ b/arch/m68k/Kconfig.debug
> > @@ -11,7 +11,7 @@ config BOOTPARAM_STRING
> > depends on BOOTPARAM
> >
> > config EARLY_PRINTK
> > - bool "Early printk" if EMBEDDED
> > + bool "Early printk"
> > depends on MVME16x || MAC
> > default y
> > help
> >
>
> My bad. When I added "|| MAC" I didn't realise that EARLY_PRINTK == y by
> default when EMBEDDED == n. You may want to send that patch in formal
> style. Or maybe this?
>
> - depends on MVME16x || MAC
> + depends on EMBEDDED && (MVME16x || MAC)
>
> Or maybe both?
On second thoughts, Laurent's patch seems like the better one. I don't
think EARLY_PRINTK is particularly relevant to EMBEDDED. I have my doubts
about the "default y" though. What do you think, Geert?
Finn
Reply to: